911075 - [Contacts] Nothing happens if the user try export contacts as vcard while the sd card is in use

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[rafael.marquez]

Attachment: 2013-08-30-07-51-44.png

*Procedure
1. Connect the device to the computer as USB storage
2. Open contacts app and enter in export to memory card
3. Select a contact and click on export contacts.

*Expected Result
An error "SD card in use" is displayed

*Actual Result
A screen with the icon "loading" appears but never ends


Device: unagi
Branch: master
Gecko: b649729
Gaia: 12731a6

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Thanks, we need to check that we are not using first the sdcard as a remote storage.

@Ayman, when we are connected via usb cable and using the sdcard as a remote storage we cannot access to it, what do you prefer, should we disable the export to media card meanwhile, or should we display a message?

Comment 2

[ayman maat :maat]

(In reply to Francisco Jordano [:arcturus] from comment #1)
> Thanks, we need to check that we are not using first the sdcard as a remote
> storage.
> 
> @Ayman, when we are connected via usb cable and using the sdcard as a remote
> storage we cannot access to it, what do you prefer, should we disable the
> export to media card meanwhile, or should we display a message?

Francisco, is it possible to action the following path:

**PATH**
prerequisite 0.1) phone has local contacts in its contact list
prerequisite 0.2) phone has USB storage turned on
prerequisite 0.3) phone is connected to computer as USB storage
1) open contacts app
2) select settings
3) select export contacts

**EXPECTED**
Memory card CTA will be disabled and not selectable
If their prerequisite conditions to be enabled are met all other available CTAs will be enabled.

ni? to Francisco to assess viability

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Hi Ayman,

good point.

Assigning to myself to work on it. Also, should we display it disabled or enabled and while trying to export (not allowing it) displaying a message about the phone being used as massive storage?

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

We will need to listen to the usb mass storage option enabled, that prevents any interaction with the sdcard.

This error will be happening in the import as well, so will fix in both.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 12077

Comment 6

[isabelrios]

Also when trying to export a contact via BT with the device connected (SD card in use) after tapping on export, nothing happens. It seems that the export fails but no clue about the reason.
Should I open a new bug or as it is related to this, can be tracked with this?

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Hi Jose,

just rebased and added the changes that you suggested.

Thanks a lot!

Comment 8

[Jose Manuel Cantera]

Comment on attachment 802338 [details]
Pointer to PR 12077

the patch is totally correct. Please check some nits.

Just to note that in my Gecko build UMS disablement was not working properly. The setting changed but the UMS remained enabled. That seems to be a Gecko issue.

thanks Francisco!

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/fc222c4fb720d97ce3933e3f8891498c9c3f49b3

Comment 10

[isabelrios]

Checked with 09/29 v1.2 build:
Gecko-e73e078
Gaia-1992915

The option to export to sd Card is disabled when in Settings, 'Enable USD storage' is enabled when the device is and when is not connected to PC.
Attaching screenshot of the message shown. ni? Ayman to confirm whether that would be ok

Comment 11

[isabelrios]

Attachment: 2013-09-30-08-51-03.png

Comment 12

[James Lal [:lightsofapollo]]

Uplifted fc222c4fb720d97ce3933e3f8891498c9c3f49b3 to:
v1.2: a8dbf4e70b5605b8f6e969064436c2ffd4e98b26

Comment 13

[ayman maat :maat]

clearing ni? to me as marked fixed