911294 - FM UI shows previously tuned frequency

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[vasanth]

Attachment: 0001-Fix-FM-UI-showing-previously-tuned-frequency.patch

This issue happens in latest devices which uses jb-gonk code base.
Reason is GonkFMRadio gets frequency immediately after setting frequency.
But radio-iris driver returns set frequency only after TUNE_SUCC event [1]
Attached fix listens to this event and get frequency after that

This issue doesn't happen with radio-tavarua driver (akami devices) but ideally we should listen to this event there as well

Also later I found that FM code is being re-written in C++ [2]. Let me know if you guys can incorporate this fix in that patch or shall I wait till that patch is merged and modify this patch accordingly

[1] https://www.codeaurora.org/cgit/quic/la/kernel/msm/tree/drivers/media/radio/radio-iris.c?h=jb_3.2.1#n2052
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=870676

Comment 1

[Pin Zhang [:pzhang] (inactive)]

Bug 870676 was backouted and will be landed again soon, so I prefer reviewing the patch based on that.

Comment 2

[Michael Vines [:m1] [:evilmachines]]

Hey Vasanth, please rebase the patch on 870676

Comment 3

[vasanth]

Attachment: 0001-Fix-FM-UI-showing-previously-tuned-frequency-V2.patch

Rebased the patch according to changes in Bug 870676.
It looks much simpler now!

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 802296 [details] [diff] [review]
0001-Fix-FM-UI-showing-previously-tuned-frequency-V2.patch

r=me for GonkFMRadio.cpp only

Comment 5

[Pin Zhang [:pzhang] (inactive)]

Comment on attachment 802296 [details] [diff] [review]
0001-Fix-FM-UI-showing-previously-tuned-frequency-V2.patch

Review of attachment 802296 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for FMRadioService.cpp

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/1b97fd52ae26

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1b97fd52ae26