Closed
Bug 913343
Opened 11 years ago
Closed 11 years ago
[FMRadio] Rename mozilla::dom::ReplyRunnable to mozilla::dom::FMRadioReplyRunnable
Categories
(Firefox OS Graveyard :: Gaia::FMRadio, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pzhang, Assigned: pzhang)
Details
Attachments
(1 file, 1 obsolete file)
|
18.46 KB,
patch
|
pzhang
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #870676 +++
I thought
|
Assignee | |
Comment 1•11 years ago
|
||
I thought it's included in the patches fo bug 870676 (bug 870676 comment 153), but it didn't, so submitted it as a separate patch.
Attachment #800607 -
Flags: review?(khuey)
|
|
Assignee | |
Updated•11 years ago
|
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [MemShrink:P3]
Comment on attachment 800607 [details] [diff] [review]
0001-Rename-ReplyRunnable-FMRadioReplyRunnable.patch
Review of attachment 800607 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/fmradio/ipc/FMRadioChild.cpp
@@ +124,1 @@
> FMRadioRequestArgs aArgs)
While you're here can you fix the indentation here?
Attachment #800607 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Fixed the indention problem mentioned in comment 2, r=khuey
Attachment #800607 -
Attachment is obsolete: true
Attachment #801971 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Assignee: nobody → pzhang
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•