Closed Bug 911668 Opened 8 years ago Closed 8 years ago
change build-in apps orientation to 'default'
In current design, the homescreen/email/calendar are fixed fixed in portrait mode in phone. Will fixed in landscape mode in tablet. So there will be a new orientation mode called 'default' from gecko, which will specify the default orientation mode. And present the correspondent mode per device. (will do that in another patch after that feature is implemented)
Summary: [homescreen][email][calendar] change orientation to 'default' → [homescreen][email][calendar][communication] change orientation to 'default'
Viral, do we have bug filed for Gecko implementation? Thanks.
update screen orientation from 'portrait-primary' to 'default' https://github.com/mozilla-b2g/gaia/pull/12016 bluetooth, calendar, camera, clock, communication, costcontrol, email, fm, homescreen, music, pdf.js, settings, sms, wallpaper, wappush, system can't test in nightly or emulator since 'default' orientation is not ready yet.
Summary: [homescreen][email][calendar][communication] change orientation to 'default' → [homescreen] change build-in apps orientation to 'default'
Assignee: nobody → gasolin
Summary: [homescreen] change build-in apps orientation to 'default' → change build-in apps orientation to 'default'
@tim, I'm not sure if we need to change system's attention_screen/lock_screen/cards_view default orientation? Since they works fine in current values.
Comment on attachment 801346 [details] pull request redirect to github This is wrong. app transition depends on the orientation, all transition would fail to happen. https://bugzilla.mozilla.org/show_bug.cgi?id=908601
system related change will be done in bug 908601
Comment on attachment 801346 [details] pull request redirect to github Since bug 908058 is landed, update PR for review. Will left system related change to another bug
DO NOT land this before 908601 since there would be a significant regression.
Comment on attachment 801346 [details] pull request redirect to github ~/repo/gaia master$ grep -rl portrait-primary apps apps/bluetooth/manifest.webapp apps/calendar/manifest.webapp apps/camera/manifest.webapp apps/clock/manifest.webapp apps/communications/manifest.webapp apps/costcontrol/manifest.webapp apps/email/manifest.webapp apps/fm/manifest.webapp apps/homescreen/manifest.webapp apps/music/manifest.webapp apps/pdfjs/manifest.webapp apps/ringtones/manifest.webapp apps/settings/manifest.webapp apps/sms/manifest.webapp apps/system/js/attention_screen.js apps/system/js/cards_view.js apps/system/js/lockscreen.js apps/system/js/sleep_menu.js apps/system/js/window.js apps/system/js/window_manager.js apps/system/style/system/system.css apps/system/test/unit/cards_view_test.js apps/wallpaper/manifest.webapp apps/wappush/manifest.webapp timdream:~/repo/gaia master$ Please make sure js file and test files are changed too.
Comment on attachment 801346 [details] pull request redirect to github add setringtone orientation, ask review again
I am a bit confused. So the patch here does not cover orientation strings in JS and tests?
after grep, only system has 'portrait-primary' orientation strings in JS and tests. I think bug 908601 covered that
Attachment #801346 - Flags: review?(timdream) → review+
merged to gaia-master 18c2ab4b7b2d4cacee90fb85e97354142b2fad4a thanks!
I was not able to uplift this bug to v1.2. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1.2 git cherry-pick -x -m1 18c2ab4b7b2d4cacee90fb85e97354142b2fad4a <RESOLVE MERGE CONFLICTS> git commit
John, this issue depends on bug 908601
it seems like bug 908601 is already uplifted. can this bug now be uplifted? thanks
There's still an issue uplifting: $ git cherry-pick -x -m1 18c2ab4b7b2d4cacee90fb85e97354142b2fad4a error: could not apply 18c2ab4... Merge pull request #12016 from gasolin/issue-911668 hint: after resolving the conflicts, mark the corrected paths hint: with 'git add <paths>' or 'git rm <paths>' hint: and commit the result with 'git commit' $ git diff * Unmerged path apps/setringtone/manifest.webapp
Flags: needinfo?(jhford) → needinfo?(gasolin)
uplift to 1.2 dbf61d49df1f4fdd3f9decf25575794b09e77d83
https://tbpl-dev.allizom.org/?tree=Mozilla-B2g26-v1.2&rev=54de309e18a9 The v1.2 patch have just turn the b2g26-v1.2 tree red. I just hit re-run if the same error show up we would have to back this patch out.
OK. False alarm.
thanks for check this
This was backed out of 1.2 for causing bug 934556: https://github.com/mozilla-b2g/gaia/commit/3259ac8a9813740ffc43a5e4fdff8e4a024a56c8 Removing blocking-b2g flag so that this doesn't get uplifted to 1.2.
You need to log in before you can comment on or make changes to this bug.