911677 - [settings] hide phone-related settings if telephony is not available

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

for non-telephony devices,

use 'navigator.mozTelephony' feature detection to hide phone-related settings

Comment 1

[[e-mail]]

@kevin, is it possible to simulate a device without navigator.mozTelephony or mozMobileConnection support on nightly?

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

After tracing the code and discussing with Arthur,

1. identify mobileConnection instead of iccHelper.enable, since iccHelper.js will be removed in the future
2. hide callsettings/cellular/SIM security/icc entries from root panel
3. remove ringtone from list for sound.js

I will implement it soon.

Comment 3

[Kevin Grandon :kgrandon]

(In reply to Fred Lin [:gasolin] from comment #1)
> @kevin, is it possible to simulate a device without navigator.mozTelephony
> or mozMobileConnection support on nightly?

It's not yet possible to do this. You could hack/disable the shim in desktop helper, but the best thing to do would probably be to add some kind of tablet simulation mode. Or perhaps some build flag that will make these shims not be included.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

This patch will check navigator.mozTelephony to hide some settings.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 800015 [details]
PR to master

There are minor suggestions I would like you to address before merging. Detail please check github, thanks for the effort!

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 800015 [details]
PR to master

Thanks for your advice. Patch is updated, please kindly check again!

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

I put some comments in github, could you check it again? Thanks!

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 800015 [details]
PR to master

Hi Arthur,

Thanks for your advice.
Patch is updated.
Please kindly review it again.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 800015 [details]
PR to master

Good work! r=me, thanks!

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks Arthur.
Merge into master, 
https://github.com/mozilla-b2g/gaia/commit/caab526a4f8c67f36d28fea5d0c9d50edf1bdcd6