91173 - Page Info window does not wrap or abbreviate (again)

Status: VERIFIED FIXED

(SeaMonkey :: Page Info, defect, P2)

Description

[Bob Lord]

The Page Info window does not handle long URLs again.

Comment 1

[Bob Lord]

Attachment: snapshot of how the long URL breaks the other tabs

Comment 2

[Daniel Brooks [:db48x]]

a dup I'm sure

Comment 3

[lchiang]

There was a fix to http://bugzilla.mozilla.org/show_bug.cgi?id=85451 with
viewing certs. Not sure if this could be related.  

Junruh - can you go a few days back on the branch to see if this feature was ok
then? Thanks.

Comment 4

[Bob Lord]

Although I suppose they might be related, I think this bug was fixed a while
ago, and the solution was to abbreviate the URL in the General tab.  So long
URLs would be clipped with "..." at the end.  

That change fixed the bad wrapping in the other tabs; the Security tab isn't the
only one affected.

Comment 5

[selmer (gone)]

I can't even consider this without seeing the patch.

Comment 6

[John Unruh]

PSM

Comment 7

[John Unruh]

Browser

Comment 8

[Asa Dotzler [:asa]]

reassign

Comment 9

[John Morrison]

--- pageInfo.xul.orig	Sun Jul 29 18:24:20 2001
+++ pageInfo.xul	Sun Jul 29 18:25:42 2001
@@ -75,11 +75,11 @@
           <rows>
             <row>
               <text class="label" value="&pageInfo.pageTitle;"/>
-              <text class="label" id="titletext" value=""/>
+              <text class="label" id="titletext" value="" crop="right"/>
             </row>
             <row>
               <text class="label" value="&pageInfo.URL;"/>
-              <text class="label" id="urltext" value=""/>
+              <text class="label" id="urltext" value="" crop="right"/>
             </row>
             <row>
               <text class="label" value="&pageInfo.lastModified;"/>


... unless Blake has a better solution. -> Blake, in lieu of any clear owner 
for that dialog.

Comment 10

[Daniel Brooks [:db48x]]

I know this is a dup, I just can't find the other bug (I wish we had a way of
showing the 'dup tree' like we can do with dependancies). Anyway, fixed by bug
52730, with pretty much exactly what John proposes, except that to fix a
different bug I use <textfield>s instead of <text>. I'll go ahead and take the
bug to get it off blake's list, which I'm sure is large enough as it is.

Comment 11

[Daniel Brooks [:db48x]]

update the dependancies and stuff.

Comment 12

[chris hofmann]

looks like this one is close.  let kill it in 0.9.5

Comment 13

[lchiang]

I wonder if we will want this for nsbranch after mozilla 0.9.4.  I looks like a
usability item with an easy (I think) fix.  nominate nsbranch and cc: grega to
see if he wants this for nsbranch.

Comment 14

[Jaime Rodriguez, Jr.]

Daniel - Will this one be fixed this week? We'd like to take it ASAP, if it is
ready?

Comment 15

[Daniel Brooks [:db48x]]

This bug is fixed by bug 52730, which I really haven't finished. On the other
hand, there's really nothing keeping the fix for bug 52730 out of the tree, I'd
just wanted to rewrite a few parts. Everything on it works correctly. I belive
gerv was very close to giving r= on it, sr= shouldn't be difficult to get
either. I would have no qualms if it were checked in today. Unfortunatly it may
not qualify as a low-risk checkin - it does add features, and therefore could
cause bugs to be filed (it can't break anything else though.)

It's up to you guys, I'll be happy to make sure the patch still applies cleanly,
etc. Note that there is another bug that I know of that touches the same files,
bug 83017. it alreay has sr=. It should be checked in first. 

Comment 16

[John Morrison]

I'll note that we can take the simple 2-line patch above on the branch, and 
fix the specific defect reported in this bug, instead of taking the larger, 
cooler, but riskier patch from Daniel (which can land for 0.9.5 instead).

Comment 17

[Daniel Brooks [:db48x]]

sounds good to me.

Comment 18

[Marek Z. Jeziorek]

nsbranch+ per pdt triage for the simple 2-line patch ONLY

Comment 19

[John Morrison]

Apologies Daniel. I'm just going to pass this over to a Netscape person to 
checkin the two-liner above for short-term purposes (i.e., nsbranch).

-> ssaux for checkin on nsbranch

Blake/Joe : can we get an r=/sr= on this two-liner.

Comment 20

[John Morrison]

Attachment: two-line patch; crop="right" on pageInfo title and URL fields

Comment 21

[Daniel Brooks [:db48x]]

no problem. I'll even let yall mark it fixed :)

Comment 22

[lchiang]

Time is running out to get this to the 0.9.4 branch.   Blake/Joe, please r and
sr on the 2-line patch for the branch, and ssaux, please bring to PDT.  In a day
or two, we will have to mark this PDT-.

Comment 23

[Stephane Saux]

Shouldn't jrgm take ownership of this bug since he proposed the patch.  I don't
have check-in privileges, and the component is not PSM.

I'm sending an email to blake/joe.

Comment 24

[Blake Ross]

r/sr=blake

Comment 25

[Joe Hewitt (gone)]

r=hewitt

Comment 26

[Stephane Saux]

Comment on attachment 49854 [details] [diff] [review]
two-line patch; crop="right" on pageInfo title and URL fields

as per Blake's and Joe's reviews.

Comment 27

[Nisheeth Ranjan]

Marking PDT+.  Joe, will you please check this in?  

Comment 28

[Joe Hewitt (gone)]

fixed on branch

Comment 29

[Stephane Saux]

I can't check this in on the trunk. Note that it made it on the 0.9.4 branch, so
I don't see why it couldn't be on the trunk as well.
remove nsbranch+ as it made it on 0.9.4

Assigning to default owner for trunk check in and milestone.

Comment 30

[Paul Chen]

uhh, don't think this is absolutely critical for 0.9.5, is it? marking 0.9.6

Comment 31

[John Unruh]

Fixed on branch 10/5 WinNT.

Comment 32

[Bob Lord]

This bug is fixed on the 094 branch, but today's trunk build still suffers from
it.  Can someone check it in on the trunk?

Comment 33

[Gervase Markham [:gerv]]

Reassigning to db48x to get the cooler patch reviewed and checked in on the trunk.

Gerv

Comment 34

[Jaime Rodriguez, Jr.]

This one has been verified on the 094 branch, right?

Comment 35

[lchiang]

Yes, junruh verified this on 10-5.  Also, Bob Lord's (reporter) comments show
this is fixed on branch

Comment 36

[lohphat]

Isn't this related to bug 64365?

Comment 37

[Asa Dotzler [:asa]]

0.9.6 is long gone. -> 0.9.7

Comment 38

[Daniel Brooks [:db48x]]

I'll be back from vacation soon.

Comment 39

[Daniel Brooks [:db48x]]

0.9.9 it is

Comment 40

[Daniel Brooks [:db48x]]

yay! finnally checked in. Thank you bz :)

Comment 41

[sairuh (rarely reading bugmail)]

mass moving resolved fixed bugs pertaining to page info, view source, find in
page and open web location to [e-mail].

to find all bugspam pertaining to this, set your search string to
"SunsComingUpLikeABigBaldHead".

Comment 42

[Patty Mac]

Verified on windows (2002-02-02-11-trunk)