912213 - Webapps getAppActor doesn't work with non-oop apps

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Alexandre Poirot [:ochameau]]

For some unknown reason Webapps actor `getAppActor` request never respond without dispatching any exception. The message manager code most likely fail silently because frame are not OOP.

This bug disallows connecting a toolbox to any non-oop app like system app, browser or keyboard.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Paul noted in my dupe (bug 913215) that he was able to get:

* Settings
* Built-in Keyboard

to work.

Settings seems to work intermittently for me, but I have never gotten Built-in Keyboard to debug.

Paul, you are still able to debug the keyboard?  I am currently running the 2013-09-09 Keon nightly unmodified, which seems to generally work, but maybe something extra is needed to get it working like you were able to.

Comment 3

[Alexandre Poirot [:ochameau]]

Settings is a regular OOP app, so I'm excepting it to work just fine.
With my custom builds using master, I get a consistent behavior where settings do work and keyboard doesn't.

Comment 4

[Paul Rouget [:paul]]

This bug is specific to non-oop apps.

Let's move this discussion back to bug 913215.

Comment 6

[Paul Rouget [:paul]]

Non working apps:

- system app
- browser
- keyboard

Comment 7

[Paul Rouget [:paul]]

I can tell, for sure, that this used to work.

Comment 8

[Alexandre Poirot [:ochameau]]

Attachment: Fix conflicts between two ContentTabActor classes r=paul

It ends up failing because of a conflict between ContentTabActor being defined here:
http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/dbg-browser-actors.js#102

and the expected one defined here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/childtab.js#23

I think that would be simplier to choose two distinct names for now,
and may be later merge these two classes, once we start offering actors for browser tabs...

Comment 9

[Paul Rouget [:paul]]

Comment on attachment 802968 [details] [diff] [review]
Fix conflicts between two ContentTabActor classes r=paul

_o/ \o/ \o_

Comment 10

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/e19b14609e52

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e19b14609e52