912280 - Implement WebGL OES_texture_half_float_linear extension

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement)

Description

[Kelsey Gilbert [:jgilbert]]

These are very similar, so we might as well do both at once.

The extension drafts are here:
http://www.khronos.org/registry/webgl/extensions/OES_texture_float_linear/
http://www.khronos.org/registry/webgl/extensions/OES_texture_half_float_linear/

An overview of how WebGL extensions are added is here: https://wiki.mozilla.org/Platform/GFX/WebGL/Contribute/Extensions

Without texture_float_linear, float textures can only be given a TEXTURE_MAG_FILTER of NEAREST, and a TEXTURE_MIN_FILTER of NEAREST or NEAREST_MIPMAP_NEAREST.

With texture_float_linear, they can have also have MAG filters of LINEAR, and MIN filters of LINEAR, LINEAR_MIPMAP_LINEAR, NEAREST_MIPMAP_LINEAR, and LINEAR_MIPMAP_NEAREST.

Comment 1

[Kelsey Gilbert [:jgilbert]]

OES_texture_float_linear was already added in bug 879954.

Comment 2

[Guillaume Abadie]

I'm ok to take it, but we should finish OES_texture_half_float first! =D

Comment 3

[Isay]

Is it alright if I take it? No one's taken it yet.

Comment 4

[Isay]

Thanks :D

Comment 5

[Florian Bösch]

Note that a sizeable percentage of chrome implements this extension (88%), it's getting time.

Comment 6

[Kelsey Gilbert [:jgilbert]]

It's been a few months, so I'll just take this and knock it out later today.

Comment 7

[Kelsey Gilbert [:jgilbert]]

Attachment: patch

Comment 8

[Kelsey Gilbert [:jgilbert]]

Attachment: patch

Forgot to add the new extension CPP file. :x

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d885b139d7d

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage. Please ensure this compiles locally and/or on Try before requesting checkin.
https://hg.mozilla.org/integration/mozilla-inbound/rev/716974a64aae

https://tbpl.mozilla.org/php/getParsedLog.php?id=34288569&tree=Mozilla-Inbound

Comment 11

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Please fix and reland ASAP -- this is blocking some gdc demo work.  Thanks!  I'll be around tomorrow in MV if you need a quick r+ on anything.

Comment 12

[Kelsey Gilbert [:jgilbert]]

(In reply to Vladimir Vukicevic [:vlad] [:vladv] from comment #11)
> Please fix and reland ASAP -- this is blocking some gdc demo work.  Thanks! 
> I'll be around tomorrow in MV if you need a quick r+ on anything.

No problem. I was just waiting on a Try run:
https://tbpl.mozilla.org/?tree=Try&rev=d561eaa4d575

I'll post the updated carry-forward-r+ patch nowish.

Comment 13

[Kelsey Gilbert [:jgilbert]]

Attachment: half-float-linear

r=kamidphish

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3faa29f938c5

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3faa29f938c5