Closed Bug 912280 Opened 7 years ago Closed 6 years ago

Implement WebGL OES_texture_half_float_linear extension

Categories

(Core :: Canvas: WebGL, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

(Whiteboard: [mentor=jgilbert][lang=c++] webgl-extension)

Attachments

(1 file, 2 obsolete files)

These are very similar, so we might as well do both at once.

The extension drafts are here:
http://www.khronos.org/registry/webgl/extensions/OES_texture_float_linear/
http://www.khronos.org/registry/webgl/extensions/OES_texture_half_float_linear/

An overview of how WebGL extensions are added is here: https://wiki.mozilla.org/Platform/GFX/WebGL/Contribute/Extensions

Without texture_float_linear, float textures can only be given a TEXTURE_MAG_FILTER of NEAREST, and a TEXTURE_MIN_FILTER of NEAREST or NEAREST_MIPMAP_NEAREST.

With texture_float_linear, they can have also have MAG filters of LINEAR, and MIN filters of LINEAR, LINEAR_MIPMAP_LINEAR, NEAREST_MIPMAP_LINEAR, and LINEAR_MIPMAP_NEAREST.
OES_texture_float_linear was already added in bug 879954.
Summary: Implement WebGL OES_texture_float_linear and OES_texture_half_float_linear extensions → Implement WebGL OES_texture_half_float_linear extension
I'm ok to take it, but we should finish OES_texture_half_float first! =D
Is it alright if I take it? No one's taken it yet.
Assignee: nobody → isay_malit
Status: NEW → ASSIGNED
Thanks :D
Note that a sizeable percentage of chrome implements this extension (88%), it's getting time.
It's been a few months, so I'll just take this and knock it out later today.
Assignee: isay_malit → jgilbert
Attached file patch (obsolete) —
Attachment #8371089 - Flags: review?(dglastonbury)
OS: Linux → All
Hardware: x86_64 → All
Attached patch patch (obsolete) — Splinter Review
Forgot to add the new extension CPP file. :x
Attachment #8371103 - Flags: review?(dglastonbury)
Attachment #8371103 - Flags: review?(dglastonbury) → review+
Attachment #8371089 - Attachment is obsolete: true
Attachment #8371089 - Flags: review?(dglastonbury)
Keywords: checkin-needed
Please fix and reland ASAP -- this is blocking some gdc demo work.  Thanks!  I'll be around tomorrow in MV if you need a quick r+ on anything.
(In reply to Vladimir Vukicevic [:vlad] [:vladv] from comment #11)
> Please fix and reland ASAP -- this is blocking some gdc demo work.  Thanks! 
> I'll be around tomorrow in MV if you need a quick r+ on anything.

No problem. I was just waiting on a Try run:
https://tbpl.mozilla.org/?tree=Try&rev=d561eaa4d575

I'll post the updated carry-forward-r+ patch nowish.
r=kamidphish
Attachment #8371103 - Attachment is obsolete: true
Attachment #8375148 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3faa29f938c5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.