912546 - page title is no longer displayed in the header

Status: RESOLVED FIXED

(bugzilla.mozilla.org Graveyard :: Sandstone/Mozilla Skin, defect)

Description

[:glob ✱]

in dusk, the page title is displayed in the header.
this is not the case in the mozilla skin.

for show_bug, this information is redundant, and should continue to be omitted.
however this isn't the case for all page.

eg. when viewing an attachment using the 'diff' view, the attachment's description is displayed only in the header, so it's no longer visible using the mozilla skin.

Comment 1

[Kai Engert [:KaiE:]]

This regression makes reviewing of patches much harder when having multiple diff tabs open, so a fix would be much appreciated. Thanks in advance.

Comment 2

[Kai Engert [:KaiE:]]

glob just told me how to use the old skin, so I reverted to that. So it's no longer necessary for me to make this a high priority, if you keep the dusk skin alive...
(kai prefering functional+ugly over shiny+incomplete)

Comment 3

[:glob ✱]

Attachment: 912546_1.patch

displaying the header on every page shows largely redundant information, so i made it display on selected pages only.  as best as i can tell we only need this on all attachment pages.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 800621 [details] [diff] [review]
912546_1.patch

r=dkl

Comment 5

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified template/en/default/global/header.html.tmpl
Committed revision 8987.

this fix won't be visible until our next production push (usually weekly).