912778 - [dev] Details page has [object object]

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: 0003screenshot.png

See https://saucelabs.com/jobs/18ef849892b04df592187329fc9a501d and the attached screenshot; on dev, with an Android browser, https://github.com/mozilla/marketplace-tests/blob/master/tests/mobile/test_details_page.py#L40 fails, resulting in [object object] :-(

http://qa-selenium.mv.mozilla.com:8080/job/marketplace.dev.mobile.saucelabs/130/HTML_Report/?

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/51068d3

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

This is better, now, but not completely fixed -- :cvan, should I reopen?

http://qa-selenium.mv.mozilla.com:8080/view/Marketplace/job/marketplace.dev.mobile.saucelabs/134/HTML_Report/?

Note the missing images, etc.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Here's the Sauce Labs job/video -- (they're having some issues, so hopefully it works): https://saucelabs.com/jobs/e43c96865bf2492292d312b3dfc71f65

Comment 4

[Christopher Van Wiemeersch [:cvan]]

(In reply to Stephen Donner [:stephend] from comment #3)
> Here's the Sauce Labs job/video -- (they're having some issues, so hopefully
> it works): https://saucelabs.com/jobs/e43c96865bf2492292d312b3dfc71f65

The missing images were something that should be addressed in bug 911352 but probably won't be.

The icon looks like something that was accidentally omitted from bug 901710. (Note to Basta/Chuck: we should probably be sending the entire app_to_dict contents since any apps in a collection object get model-cached by Fireplace.)

Stephen, thanks for the catch! If you can file for the separate icon/screenshots issue, I'm sure Chuck can fix it asap. Thanks!

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #4)

Bug 912838.  <3

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED, thanks.