Closed
Bug 912832
Opened 11 years ago
Closed 11 years ago
Inverse tiers and subtiers
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla26
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
15.18 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Currently, a top-level build is doing make export, make libs, make tools for each tier. I want to inverse this and have the top-level build do make export, make libs, make tools, with each traversing tiers.
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #799937 -
Flags: review?(gps)
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 799937 [details] [diff] [review]
Inverse tiers and subtiers for build traversal
This breaks incremental builds :(
Attachment #799937 -
Flags: review?(gps)
Assignee | ||
Comment 3•11 years ago
|
||
Fixed a typo. The incremental build breakage is due to something else i'll file a separate bug for.
Attachment #799961 -
Flags: review?(gps)
Assignee | ||
Updated•11 years ago
|
Attachment #799937 -
Attachment is obsolete: true
Comment 4•11 years ago
|
||
Comment on attachment 799961 [details] [diff] [review]
Inverse tiers and subtiers for build traversal
Review of attachment 799961 [details] [diff] [review]:
-----------------------------------------------------------------
Can't wait to see how this pays off...
::: Makefile.in
@@ +83,1 @@
> $(RM) -r $(DIST)/sdk
Do we not have a purge manifest for this :/
Attachment #799961 -
Flags: review?(gps) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Assignee | ||
Comment 6•11 years ago
|
||
Touch CLOBBER:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fdea282eb31d
Fixup for static analysis builds: (irc-r=jcranmer, after the fact)
https://hg.mozilla.org/integration/mozilla-inbound/rev/e197b9e71614
Assignee | ||
Comment 7•11 years ago
|
||
And a fixup to the fixup.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c76b5ba14102
Assignee | ||
Comment 8•11 years ago
|
||
And another one.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6412aa5cc28
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9993d1e6185e
https://hg.mozilla.org/mozilla-central/rev/fdea282eb31d
https://hg.mozilla.org/mozilla-central/rev/e197b9e71614
https://hg.mozilla.org/mozilla-central/rev/c76b5ba14102
https://hg.mozilla.org/mozilla-central/rev/c6412aa5cc28
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Comment 10•11 years ago
|
||
Personally I found it very convenient to be able to make libs_tier_app and only make those dirs in tier_app_dirs. Would something like make libs TIERS=app work instead?
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•