Inverse tiers and subtiers

RESOLVED FIXED in mozilla26

Status

defect
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla26
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Currently, a top-level build is doing make export, make libs, make tools for each tier. I want to inverse this and have the top-level build do make export, make libs, make tools, with each traversing tiers.
(Assignee)

Updated

6 years ago
Depends on: 912801, 912795
(Assignee)

Comment 1

6 years ago
Attachment #799937 - Flags: review?(gps)
(Assignee)

Comment 2

6 years ago
Comment on attachment 799937 [details] [diff] [review]
Inverse tiers and subtiers for build traversal

This breaks incremental builds :(
Attachment #799937 - Flags: review?(gps)
(Assignee)

Comment 3

6 years ago
Fixed a typo. The incremental build breakage is due to something else i'll file a separate bug for.
Attachment #799961 - Flags: review?(gps)
(Assignee)

Updated

6 years ago
Attachment #799937 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Depends on: 912845
(Assignee)

Updated

6 years ago
Blocks: 912856
Comment on attachment 799961 [details] [diff] [review]
Inverse tiers and subtiers for build traversal

Review of attachment 799961 [details] [diff] [review]:
-----------------------------------------------------------------

Can't wait to see how this pays off...

::: Makefile.in
@@ +83,1 @@
>  	$(RM) -r $(DIST)/sdk

Do we not have a purge manifest for this :/
Attachment #799961 - Flags: review?(gps) → review+
(Assignee)

Comment 6

6 years ago
Touch CLOBBER:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fdea282eb31d

Fixup for static analysis builds: (irc-r=jcranmer, after the fact)
https://hg.mozilla.org/integration/mozilla-inbound/rev/e197b9e71614
Personally I found it very convenient to be able to make libs_tier_app and only make those dirs in tier_app_dirs. Would something like make libs TIERS=app work instead?
(Assignee)

Updated

6 years ago
Depends on: 913968

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.