Closed
Bug 912869
Opened 11 years ago
Closed 10 years ago
Rename key names, "Apps" and "FastFwd" to "MediaApps" and "MediaFastForward"
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
3.07 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•11 years ago
|
Summary: Rename key name "FastFwd" with "MediaFastForward" → Rename key names, "FastFwd" and "MediaTrackSkip" to "MediaFastForward" and "MediaSkip"
Assignee | ||
Updated•10 years ago
|
Summary: Rename key names, "FastFwd" and "MediaTrackSkip" to "MediaFastForward" and "MediaSkip" → Rename key names, "Apps", "FastFwd" and "MediaTrackSkip" to "MediaApps", "MediaFastForward" and "MediaSkip"
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Summary: Rename key names, "Apps", "FastFwd" and "MediaTrackSkip" to "MediaApps", "MediaFastForward" and "MediaSkip" → Rename key names, "Apps" and "FastFwd" to "MediaApps" and "MediaFastForward"
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
This patch also comments out "MediaApps" since the Android's KEYCODE_APP_SWITCH is really different function from current D3E's definition.
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8434798 [details] [diff] [review]
Patch
D3E defines the meaning of "MediaApps" more specific at renaming it from "Apps". So, we should not map it to KEYCODE_APP_SWITCH of Android anymore since the keycode means switching between launched applications.
Attachment #8434798 -
Flags: review?(bugs)
Comment on attachment 8434798 [details] [diff] [review]
Patch
https://bugzilla.mozilla.org/show_bug.cgi?id=900374#c4 applies here too.
Attachment #8434798 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•