912974 - Split two classes out of GLContext.h, and remove many #includes in GLContext.h

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Split two classes out of GLContext.h, and remove many #includes in GLContext.h

Bug 912042 was about having fewer people accidentally include GLContext.h. But there remains dozens of cpp files that include GLContext.h because they actually have to. The only way to speed that up is to make GLContext.h less expensive to include. I looked at making it #include fewer headers and it turned out that that was possible especially if we split a couple of auxilliary classes out of it. For example, <stack> was only needed for TextureGarbageBin, and "nsIMemoryReporter.h" was only needed for GfxTexturesReporter.

And then, there were the completely unneeded includes like <set>.

On try:
https://tbpl.mozilla.org/?tree=Try&rev=7ec397814580

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Also note that GetBitsPerTexel was only used for GfxTexturesReporter so it moves there and becomes static to that file. As opposed to being declared in GLContext.h and implemented in GLContextUtils.cpp.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/integration/mozilla-inbound/file/e2f23b6aaf75

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e2f23b6aaf75

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Forgot the include guards!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 802571 [details] [diff] [review]
Forgot the include guards!

And I almost got credit for this patch too if I hadn't been paying attention! But seriously, please make sure you have Mercurial configured to include your name on your patches.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea05a04019d8

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

Oops, not sure how it happened... I obviously do have mercurial configured and the patch on my hard drive currently does have my account info... mystery!

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ea05a04019d8