Closed
Bug 912976
Opened 11 years ago
Closed 11 years ago
Remove Makefile.in boilerplate from UX branch
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
(Whiteboard: [Australis:M9][Australis:P1])
Attachments
(1 file)
2.05 KB,
patch
|
jaws
:
review+
glandium
:
review+
|
Details | Diff | Splinter Review |
Per https://groups.google.com/forum/?fromgroups#!topic/mozilla.dev.platform/EirpsT8JeYE , the boilerplate in our browser/components/customizableui/src/ Makefile can be removed, which would leave the file empty, so maybe we can remove it completely? (if so, yay!)
The one in test/ needs to stay because of MOCHITEST_BROWSER_FILES, but we can remove the boilerplate there, too, I believe?
I do not think (but haven't checked!) that we have any other new Makefile.ins in our tree. If we do, we should update those, too, obviously.
We should update our files before landing on m-c, hence M9 + P1.
Assignee | ||
Comment 1•11 years ago
|
||
This should do the trick. I checked a diff with m-c and AFAICT there are no other makefiles we introduced.
Attachment #800218 -
Flags: review?(jaws)
Updated•11 years ago
|
Attachment #800218 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Whiteboard: [Australis:M9][Australis:P1] → [Australis:M9][Australis:P1][fixed-in-ux]
Comment 3•11 years ago
|
||
m-c rules for makefile changes of this sort require that you get build peer review, fwiw.
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 800218 [details] [diff] [review]
Remove makefile.in boilerplate,
Greg, could you check that I've done the right thing here? Sorry for getting the wrong review here! :-(
Attachment #800218 -
Flags: review?(gps)
Updated•11 years ago
|
Attachment #800218 -
Flags: review?(gps) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M9][Australis:P1][fixed-in-ux] → [Australis:M9][Australis:P1]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•