913195 - (mozilla-esr24) Create mozilla-esr24 branch

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Like bug 796995, but for esr24 this cycle.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

See also https://wiki.mozilla.org/ReleaseEngineering/How_To/Create_new_ESR_branch. I'm going to get this started at least.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [graphs] mozilla-esr24

I'm pretty sure some of these are unnecessary, eg OS_X_10.5.2, but not enough to leave them out and want to deal with any fallout.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: buildbot-configs

This is based pretty heavily on attachment 678814 [details] [diff] [review]. Please use hg import --no-commit, patch won't like the 'hg copy' I've used.

For the tests configs I've matched dumped configs with beta (except where the branch should change: names, repo_path etc). One thing of note, mozilla-tests/config.py never had this removed:
 # MERGE DAY remove the below when Firefox 24 merges in
 BRANCHES['mozilla-beta']['mozharness_talos'] = False
 # END MERGE DAY remove the below when Firefox 24 merges in
I've set ESR24 to have that True immediately, and we should switch beta during the merge next week.

For the builds I've kinda merged beta and esr17 with s/17/24/, using dumps of the config to crosscheck. There's alot of differences which can be explained by no nightlies on beta but there is on esr24, no android on esr24, etc.

For the releases I've added an empty release-firefox-mozilla-esr24.py since the automation never does an hg add, otherwise all the info is in the template. Config for l10nUsePymake, hgSshKey, mock has come over from the beta configs.

It passes checkconfig on all types of master.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: tools wip

Based on attachment 678767 [details] [diff] [review]. This doesn't have anything for the mozconfig whitelists, as I've run out of time. Also kinda hard to test without having them committed to a repo yet, and RelMan making the mozconfig changes needed.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 800709 [details] [diff] [review]
buildbot-configs

I didn't include l10n-mozconfigs here because I thought we had swapped to the in-tree ones, eg 
  http://hg.mozilla.org/releases/mozilla-beta/file/ff5ae3399276/browser/config/mozconfigs/linux32/l10n-mozconfig
Certainly a linux64 repack for 24.0b8 found gcc 4.7 instead of the 4.5 in 
  http://hg.mozilla.org/build/buildbot-configs/file/7d14e428abeb/mozilla2/linux64/mozilla-beta/release/l10n-mozconfig

But the buildbot-configs patch on bug 902066 is needed for 24.0 (bug 902293) and now I'm confused.

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 800709 [details] [diff] [review]
buildbot-configs

Review of attachment 800709 [details] [diff] [review]:
-----------------------------------------------------------------

This looks reasonable. I'm going to land it today and fire off a set of builds to test it out. https://i.chzbgr.com/maxW500/6615104768/h1572A94C/

Comment 7

[[e-mail] (:bhearsum)]

buildbot-configs patch is in production

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 800542 [details] [diff] [review]
[graphs] mozilla-esr24

http://hg.mozilla.org/graphs/rev/4518a0866a15

Ran the new insert lines against staging and prod databases.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

I pushed the most recent changesets from mozilla-beta to mozilla-esr24, and it was full of green!
https://tbpl.mozilla.org/?tree=Mozilla-Esr24&rev=839b8438b2b8

ToDo: 
* tools changes, notably mozconfig whitelist
* deploy symlinks for release configs to masters

Comment 10

[Ed Morley [:emorley]]

Looks good to me! :-)

(The all-green push is likely due to the OrangeFactor being pretty low on Beta right now, thanks to all the intermittent-failure fix backports by Ryan :-))

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: tools

I tested the mozconfig changes locally, otherwise the same sort of thing as we did for esr17.

Comment 12

[[e-mail] (:bhearsum)]

Comment on attachment 801530 [details] [diff] [review]
tools

Review of attachment 801530 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 13

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 801530 [details] [diff] [review]
tools

https://hg.mozilla.org/build/tools/rev/d02cf1d5ac00

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sadly we missed to update our mozmill-ci instance early enough to get notified about the first set of testing builds. But we are currently working on getting supported landed by today (https://github.com/mozilla/mozmill-ci/pull/287). So we should catch the next set of builds.

Comment 15

[Nick Thomas [:nthomas] (UTC+12)]

Symlinks set up on masters.

$ python manage_masters.py -f production-masters.json -R build  add_esr24_symlinks
[buildbot-master57.srv.releng.use1.mozilla.com] run: ln -s /builds/buildbot/build1/buildbot-configs/mozilla/release-firefox-mozilla-esr24.py /builds/buildbot/build1/master/
[buildbot-master57.srv.releng.use1.mozilla.com] run: ln -s /builds/buildbot/build1/buildbot-configs/mozilla/l10n-changesets_mozilla-esr24 /builds/buildbot/build1/master/
[buildbot-master57.srv.releng.use1.mozilla.com] run: ln -s /builds/buildbot/build1/buildbot-configs/mozilla/release-thunderbird-comm-esr24.py /builds/buildbot/build1/master/
[buildbot-master57.srv.releng.use1.mozilla.com] run: ln -s /builds/buildbot/build1/buildbot-configs/mozilla/l10n-changesets_thunderbird-esr24 /builds/buildbot/build1/master/
[OK] Added esr24 symlinks in buildbot-master57.srv.releng.use1.mozilla.com:/builds/buildbot/build1
etc etc

Comment 16

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbot-configs] fix test-masters

I though I'd be smart and let the template create release-firefox-mozilla-esr24.py, but test-masters needs it before then.

Comment 17

[Rail Aliiev [:rail]]

Comment on attachment 801870 [details] [diff] [review]
[buildbot-configs] fix test-masters

Rubber stamp, it will be replaced by ship-it.

Comment 18

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 801870 [details] [diff] [review]
[buildbot-configs] fix test-masters

https://hg.mozilla.org/build/buildbot-configs/rev/6f61267de30e

Comment 19

[Nick Thomas [:nthomas] (UTC+12)]

Ready to build a release on our side. Code completion and bug 914121 still pending from RelMan.