913229 - [MP] Defect - Snapped displays cropped multi-column tiles after touch scroll

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Firefox Start, defect, P2)

Description

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: snappedHoriz.png

If I touch scroll the start page then snap, the top sites are displayed full size and with multiple columns. They change back once you try to touch scroll which is crazy.

Comment 1

[Marco Mucci [:MarcoM]]

Hi Rodrigo, is this a new defect or is it related to an open story under development?

Comment 2

[Rodrigo Silveira [:rsilveira] [:rodms]]

It's a new defect.

Comment 3

[Matt Brubeck (:mbrubeck)]

Is this a regression from part 1 of bug 891056?

Comment 4

[Rodrigo Silveira [:rsilveira] [:rodms]]

No, I'm seeing this without your changes.

Comment 5

[Sam Foster [:sfoster] (he/him)]

I have been seeing this too. If you just try to select one of the tiles it snaps to the correct single column arrangement. Doing that shouldn't trigger rearrangeItems, so I think somehow the layout isn't being updated. Accessing offsetWidth on the grid's bound node or something like that might trigger it?

Comment 6

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: 913229.patch

This was a tricky one. The layout was wrong because the media queries were not being triggered. They were not being triggered because the #browsers deck had a much larger width then the viewport (like ~ 1000px). The deck's width was large because #horizontal-scroller had a large width attribute.

The precise input broadcaster starts as precise, so our panning scrollers are initialized and a width/height set according to start page. When we touch, they're hidden by transitioning the opacity to 0 - they're still part of the layout though.

Fixed by unsetting width/height when hiding scrollbars.

Comment 7

[Rodrigo Silveira [:rsilveira] [:rodms]]

https://hg.mozilla.org/integration/fx-team/rev/92b84e142f38

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/92b84e142f38

Comment 9

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #15 without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-09-30-03-02-05-mozilla-central/

- Reproduced the original issue described from comment #0 with an older version of Nightly
- Ensured that the original issue described from comment #0 worked without any issues
- Ensured that sliding Firefox Metro into snapped view from filled view worked without any issues (both left and right sides of the screen)
- Ensured that all the other menu's appeared correctly when in snapped view (Top Sites, Bookmarks, Recent History)
- Loaded a lot of "Top Sites" and "Recent History" and ensured that columns are properly aligned once in snapped view
- Ensured that the columns are correctly returned when sliding Firefox Metro snapped view into filled view