913281 - Mozharness should explicitly pass --use-device-libs to runtestsb2g.py

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Mihnea Dobrescu-Balaur (:mihneadb)]

Since we don't have access to the build directory, we are missing the required libs for running xpcshell on B2G devices/emulators. Bug 912909 adds a fallback logic for this but we should explicitly pass --use-device-libs in mozharness for clarity.

Comment 1

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: Mozharness should explicitly pass --use-device-libs to runtestsb2g.py

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Jonathan, can you check this in please? :)

Comment 3

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/build/mozharness/rev/0c69cd1a61bc

Comment 4

[Jonathan Griffin (:jgriffin)]

merged to production

Comment 5

[Jonathan Griffin (:jgriffin)]

backed out for breaking xpcshell tests on mozilla-b2g18:  http://hg.mozilla.org/build/mozharness/rev/ebed70ba91c0

full log: https://tbpl.mozilla.org/php/getParsedLog.php?id=27648267&tree=Mozilla-B2g18&full=1

Comment 6

[Mihnea Dobrescu-Balaur (:mihneadb)]

Oh, right. We were not running the tests, basically. This actually makes us run them, and we uncovered the failures. I'll link the log in the other bug.

Comment 7

[Mihnea Dobrescu-Balaur (:mihneadb)]

:echen, could you please sort out the dependencies for this bug? I'm not sure if the tests that are failing here are the same as the one you reported in bug 912909. Thanks!

Comment 8

[Edgar Chen [:edgar]]

(In reply to Mihnea Dobrescu-Balaur (:mihneadb) from comment #7)
> :echen, could you please sort out the dependencies for this bug? I'm not
> sure if the tests that are failing here are the same as the one you reported
> in bug 912909. Thanks!

Mihnea, sorry for the late reply.

From the log (comment #5), there are two failed test cases related to RIL:
1). dom/system/gonk/tests/test_ril_worker_mmi.js, 
    Same issue as bug 893791, we need to uplift the patch of bug 893791 to b2g18, but need to get approval first.
    I will do this in bug 893791.

2). dom/mobilemessage/tests/test_mms_pdu_helper.js,
    The patch part 2 of bug 912442 will fix this, and same as above, we need to uplift to b2g18.

Thanks

Comment 9

[Jonathan Griffin (:jgriffin)]

Looks like this is safe to land again.  If it causes any additional failures on mozilla-b2g18, I'll disable them on that tree after filing a bug.

Comment 10

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/build/mozharness/rev/5d67be345b54; will try on cedar before merging to production

Comment 11

[Jonathan Griffin (:jgriffin)]

cedar looks fine; will let this ride the next default-production merge in mozharness

Comment 12

[Jonathan Griffin (:jgriffin)]

just merged to production: http://hg.mozilla.org/build/mozharness/rev/00a435c8d8d9

Comment 13

[John Hopkins (:jhopkins)]

in production