913397 - [Keyboard] Make keyboard app support 1.5x graphics

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Luke Chang [:lchang] (inactive)]

We will get a new look of the pinyin IME after Bug 900907 land.
Do we need 1.5x graphics for the assets we added in that patch?

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Please help test the new UX introduced by Bug 900907 on hd device, like helix or S2 and see if all the graphics is ok.

Thanks.

Comment 2

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request

Comment 3

[Preeti Raghunath(:Preeti)]

Luke,

Any updates with this bug? Who else do we need a review from?

Comment 4

[Luke Chang [:lchang] (inactive)]

Hi Preeti, I'm waiting for Rudy's review.

Hi Rudy, Do you have any update for this patch, thanks.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 806398 [details]
Pull Request

r+, with the CSS unit should be in 'rem'.
Thanks.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Sorry for the delay.

I don't have a chance to test this on device, please help make sure it looks OK on WVGA device.
Thanks.

Comment 7

[Luke Chang [:lchang] (inactive)]

I've updated my patch. Thanks Rudy.

Comment 8

[Luke Chang [:lchang] (inactive)]

travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/12555016

merged in gaia master:
https://github.com/mozilla-b2g/gaia/commit/17e871ae1f82699793e3cd28acda805ba724a8b6

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 17e871ae1f82699793e3cd28acda805ba724a8b6 to:
v1.2: 3e34df22eaa1d75225f55deae79ce96e50cd7823