Closed Bug 913397 Opened 11 years ago Closed 11 years ago

[Keyboard] Make keyboard app support 1.5x graphics

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g koi+
Tracking Flags:
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: lchang, Assigned: lchang)

References

Details

Attachments

(1 file)

Pull Request
335 bytes, text/html
rudyl
: review+
Details 
We will get a new look of the pinyin IME after Bug 900907 land.
Do we need 1.5x graphics for the assets we added in that patch?
Please help test the new UX introduced by Bug 900907 on hd device, like helix or S2 and see if all the graphics is ok.

Thanks.
Summary: [Keyboard] Do we need 1.5x graphics for the pinyin IME? → [Keyboard] Make keyboard app support 1.5x graphics
Attached file Pull Request — 

        Attachment #806398 -
        Flags: review?(rlu)

    
  
Assignee: nobody → lchang

    
  
blocking-b2g: koi? → koi+

    
    

    
  
Luke,

Any updates with this bug? Who else do we need a review from?
Flags: needinfo?(lchang)

    
    

    
  
Hi Preeti, I'm waiting for Rudy's review.

Hi Rudy, Do you have any update for this patch, thanks.
Flags: needinfo?(lchang) → needinfo?(rlu)

    
    

    
  
Comment on attachment 806398 [details]
Pull Request

r+, with the CSS unit should be in 'rem'.
Thanks.

        Attachment #806398 -
        Flags: review?(rlu) → review+

    
    

    
  
Sorry for the delay.

I don't have a chance to test this on device, please help make sure it looks OK on WVGA device.
Thanks.
Flags: needinfo?(rlu)

    
    

    
  
I've updated my patch. Thanks Rudy.
Flags: needinfo?(rlu)

    
    

    
  
travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/12555016

merged in gaia master:
https://github.com/mozilla-b2g/gaia/commit/17e871ae1f82699793e3cd28acda805ba724a8b6
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(rlu)
Resolution: --- → FIXED

    
    

    
  
Uplifted 17e871ae1f82699793e3cd28acda805ba724a8b6 to:
v1.2: 3e34df22eaa1d75225f55deae79ce96e50cd7823

          status-b2g-v1.2:
          --- → fixed

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: