913402 - The bookmark added notification toast doesn't disappear from the screen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Build: Firefox for Android 24.0b8 (2013-09-05)
Device: LG Slider
OS: Android 2.3.4

Steps to Reproduce:
1. Go to google.com
2. Tap Menu -> Bookmark

Expected:
- A toast notification appears "Bookmark added" and after a few seconds it disappears

Actual:
- The toast notification doesn't disspear from the screen 
Please se attached video:http://www.youtube.com/watch?v=v5aQZl03fQ0

Note: 
-latest Nightly is not affected

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Is it possible to get a regression window for the fix?

Comment 2

[Teodora Vermesan (:TeoVermesan)]

Regression window-wanted:
not affected build: 24 beta 6
affected build: 24 beta 8
-pushlog:
http://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=a1b8988d564a&tochange=1ad379ebe463

I've tryed with the nightly builds and couldn't find any affected ones ( for example 27/08 build when Bug 885717 was fixed, 05/09 build when Bug 899560 was fixed, or 14/06 build when Bug 872388 was integrated

Comment 3

[Aaron Train [:aaronmt]]

Can you confirm if simply Android 2.3 or other small screen devices are affected? I don't see the significance of ARMv6 here at all.

From that range it looks like bug 899560 is the cause for a regression here.

Comment 4

[Teodora Vermesan (:TeoVermesan)]

I cannot reproduce it on Samsung Galaxy R (Android 2.3), Alcatel one touch(Android 2.3.6)  and we don't have other small screen devices.

Comment 5

[Aaron Train [:aaronmt]]

(In reply to Teodora Vermesan (:TeoVermesan) from comment #0)
> Please se attached video:http://www.youtube.com/watch?v=v5aQZl03fQ0
> 
> Note: 
> -latest Nightly is not affected

Can you open the video up for public viewing?

Comment 6

[bhavana bajaj [:bajaj]]

I am tracking this as this is a recent regression.

:mfinkle, Aaron and I discussed this and given this may not happen on a lot of devices I am not recommending backout of the patch in https://bugzilla.mozilla.org/show_bug.cgi?id=899560 for our last beta going to build today.

Let us know if there is any other action needed here for Fx24, else given the timeline's likely a wontfix for that version.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to bhavana bajaj [:bajaj] from comment #6)
> I am tracking this as this is a recent regression.
> 
> :mfinkle, Aaron and I discussed this and given this may not happen on a lot
> of devices I am not recommending backout of the patch in
> https://bugzilla.mozilla.org/show_bug.cgi?id=899560 for our last beta going
> to build today.
> 
> Let us know if there is any other action needed here for Fx24, else given
> the timeline's likely a wontfix for that version.

This sounds fine to me.

Comment 8

[Wesley Johnston (:wesj)]

I can reproduce this on a wildfire s for beta (not for nightly).

Comment 9

[Adrian Tamas (:AdrianT)]

Issue is reproducible on Firefox Mobile 24 beta 10 on the Samsung Galaxy R (Android 2.3.4 - ARMv7)

Comment 10

[Wesley Johnston (:wesj)]

This is fixed with the alternative patch https://bugzilla.mozilla.org/attachment.cgi?id=792441. I remember seeing this somewhere else as well. I think we just killed animations on GB there?

Lucas, do you know why the PropertyAnimator has trouble with these alpha animations on some devices?

Comment 11

[Lucas Rocha (:lucasr)]

(In reply to Wesley Johnston (:wesj) from comment #10)
> This is fixed with the alternative patch
> https://bugzilla.mozilla.org/attachment.cgi?id=792441. I remember seeing
> this somewhere else as well. I think we just killed animations on GB there?
> 
> Lucas, do you know why the PropertyAnimator has trouble with these alpha
> animations on some devices?

OnPreDrawObserver seems busted on pre-HC devices. I have a fix for this on bug 910191.

Comment 12

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/fx-team/rev/a0cad0d1d7fc

Comment 13

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/mozilla-central/rev/a0cad0d1d7fc

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/51a7fba55698

Comment 15

[Alex Keybl [:akeybl]]

Nominate for approval when ready.

Comment 16

[Lucas Rocha (:lucasr)]

(In reply to Alex Keybl [:akeybl] from comment #15)
> Nominate for approval when ready.

Interestingly, Beta does not have the code with the issue I fixed. Can this bug actually be reproduced in Beta?

Comment 17

[Ioana Chiorean]

I was able to reproduce it with yesterday's beta build 25 Beta 2 build 1 on LG Slider. 
Steps to Reproduce:
1. Go to google.com (or any other page)
2. Tap Menu -> Bookmark

Comment 18

[Lucas Rocha (:lucasr)]

(In reply to Ioana Chiorean from comment #17)
> I was able to reproduce it with yesterday's beta build 25 Beta 2 build 1 on
> LG Slider. 
> Steps to Reproduce:
> 1. Go to google.com (or any other page)
> 2. Tap Menu -> Bookmark

That makes me wonder if my patch actually fixes the bug. Can you reproduce it in Nightly and/or Aurora?

Comment 19

[Ioana Chiorean]

Works fine on Aurora (the toast disappears after a few seconds.) Can't check on Nightly due to Bug 920558. After it gets fixed will try on Nightly too.

Comment 20

[Lucas Rocha (:lucasr)]

(In reply to Ioana Chiorean from comment #19)
> Works fine on Aurora (the toast disappears after a few seconds.) Can't check
> on Nightly due to Bug 920558. After it gets fixed will try on Nightly too.

Bug 920558 is now fixed. Could you try to reproduce this bug in Nightly?

Comment 21

[Ioana Chiorean]

Fennec 27.0a1 (09/30) using LG Slider 
Works fine on Nightly build too (the toast disappears after a few seconds.)

Comment 22

[Aaron Train [:aaronmt]]

Is 25 still affected here? Or was this fixed on Aurora before the merge?

Comment 23

[Adrian Tamas (:AdrianT)]

Still an issue on Firefox Mobile 25 beta 4 on the LG Slider (Android 2.3)

Comment 24

[Aaron Train [:aaronmt]]

Lucas, uplift to 25?

Comment 25

[Jefferson]

Please uplift.

SuMo thread today with 3 Gingerbread users affected: https://support.mozilla.org/questions/973954

Any workarounds we can post in the thread?

Comment 26

[Alex Keybl [:akeybl]]

(In reply to Aaron Train [:aaronmt] from comment #24)
> Lucas, uplift to 25?

From email, "Beta (Fx25) does not have the code that was causing the bug in Aurora and Nightly in the first place. I guess we'll need a Fx25-specific patch for bug 913402 as the issue seem to be different there."

Not sure what the chances are of getting a fix in today though, and I don't think we'd consider a fix for next week.

Comment 27

[Wesley Johnston (:wesj)]

build here: http://people.mozilla.com/~wjohnston/toast.apk

Margaret, can you test it?

Comment 28

[:Margaret Leibovic]

(In reply to Wesley Johnston (:wesj) from comment #27)
> build here: http://people.mozilla.com/~wjohnston/toast.apk
> 
> Margaret, can you test it?

Works for me on my Nexus S (2.3.6)

Comment 29

[Lucas Rocha (:lucasr)]

Assigning to Wes as he's working on a fix for Fx25.

Comment 30

[Alex Keybl [:akeybl]]

Does bug 924902 mean we can untrack this bug for FF25?

Comment 31

[Lucas Rocha (:lucasr)]

(In reply to Alex Keybl [:akeybl] from comment #30)
> Does bug 924902 mean we can untrack this bug for FF25?

The steps to reproduce and symptoms seem to be slightly different. I'd probably keep it tracking 25, just in case.

Comment 32

[Wesley Johnston (:wesj)]

I can't reproduce this on any devices I have. Aaron, can you test?

Comment 33

[Aaron Train [:aaronmt]]

I've never been able to, over to Teodora whom filed this

Comment 34

[u421692]

Verified as FIXED on latest beta tinderbox build: http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-beta-android/1382146610/ , on Samsung Galaxy R (Android 2.3.4).

On Firefox 25 Beta 8 the issue is still reproducing.

Comment 35

[u421692]

Verified as fixed on Samsung Galaxy R(Android 2.3.4), on Firefox RC 25 build 3.