924902 - [Gingerbread] Bookmark toast notification remnants remain on-screen blocking content

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[u421692]

Environment:
Device: HTC Desire HD (Android 2.3.5)
Build: Nightly 27.0a1 (2013-10-09)

Steps to reproduce:
1. Open Firefox
2. Go to a website
3. Tap on the Bookmark button
4. Wait for the toast notification to disappear
5. Tap on the screen where the notification was

Expected results:
The content that is now on the position where the notification was can be tapped.  

Actual results:
If there is a link on the position where the notification was, tapping on the link will not perform any action.

Note: I was able to reproduce this only on gingerbread devices. 
! on Firefox 24 and 25 the bookmark toast remains on the screen, the behaviour exactly like in Bug 913402. Maybe this is a regression from bug 913402?

Please see the video: 
https://www.youtube.com/watch?v=9-VjUib614w

Comment 2

[Lucas Rocha (:lucasr)]

I wonder how this bug is related to bug 913402?

Comment 3

[Wesley Johnston (:wesj)]

I saw this behaviour before (even on ICS) using the old code.

It should have been switched with the PropertyAnimator stuff, which is on 25. I'm going to propose we disable these fade out animations pre-ICS for 25. Patch coming (but I don't have a device to test this on).

Comment 4

[:Margaret Leibovic]

(In reply to Wesley Johnston (:wesj) from comment #3)
> I saw this behaviour before (even on ICS) using the old code.
> 
> It should have been switched with the PropertyAnimator stuff, which is on
> 25. I'm going to propose we disable these fade out animations pre-ICS for
> 25. Patch coming (but I don't have a device to test this on).

I was able to reproduce this issue on my Nexus S, so I can help you test if you need me to.

Comment 5

[Wesley Johnston (:wesj)]

Attachment: Turn off patch

Thanks! Had to clobber and build. Will post a link when its done, but here's that patch I'm trying.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 816727 [details] [diff] [review]
Turn off patch

Looks reasonable for disabling the animation.

Let's verify this fixes the problem before landing :)

Comment 7

[Wesley Johnston (:wesj)]

Comment on attachment 816727 [details] [diff] [review]
Turn off patch

gah! I've got to many bugs with this same title. Margaret confirmed this worked in bug 913402. 

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 880454
User impact if declined: Toast disappears, but still blocks content
Testing completed (on m-c, etc.): Not applicable to central.
Risk to taking this patch (and alternatives if risky): Uplift the other patches? Backing out this feature would also not be impossible.
String or IDL/UUID changes made by this patch: None.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

I'm lost as to what the resolution/TM/status flags for this bug are supposed to be.

https://hg.mozilla.org/releases/mozilla-beta/rev/a62a105f3302

Comment 9

[Aaron Train [:aaronmt]]

Is this fixed on the latest mozilla-beta builds (this is pending next beta candidate)? http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-beta-android/

Comment 10

[u421692]

Verified as fixed on HTC Desire HD (Android 2.3.5), on latest http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-beta-android/1382146610/ tinderbox build.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Does this still require action for Fx27?

Comment 12

[Kevin Brosnan [Ex-Mozilla]]

I'll double check in the morning.

Comment 13

[u421692]

Verified as fixed on HTC Desire HD (Android 2.3.5), on Firefox RC 25 build 3.

Comment 14

[Kevin Brosnan [Ex-Mozilla]]

No action needed for Fx 27 this works as expected.