Gecko needs to return a proper error code when sending messages to non-FDN receivers

RESOLVED FIXED in Firefox 26

Status

()

defect
P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: airpingu, Assigned: airpingu)

Tracking

({feature})

Trunk
mozilla26
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:koi+, firefox26 fixed)

Details

(Whiteboard: [MOZ][UCID:Comms8, FT:comms, KOI:P1], [u=commsapps-user c=dialer p=0][Sprint 2][Status: UX provided initial spec, Gaia working on it])

Attachments

(1 attachment, 1 obsolete attachment)

+++ This bug was initially created as a clone of Bug #913421 +++

To satisfy the user story at Bug #913421, we need to make Gecko be able to return a proper error code like "FdnCheckError" to Gaia when users attempt to send messages to a receiver that is not in the FDN list. In this way, the users can be notified that the reason why sending SMS fails is specifically due to the FDN check error, instead of a generic error.
Posted patch Patch (obsolete) — Splinter Review
Waiting on the feedback at bug 913421, comment #1.
Comment on attachment 800748 [details] [diff] [review]
Patch

According to bug 913421, comment #2. We only need to support for SMS.
Attachment #800748 - Flags: review?(vyang)
Comment on attachment 800748 [details] [diff] [review]
Patch

Review of attachment 800748 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +3097,5 @@
>                error = Ci.nsIMobileMessageCallback.NO_SIGNAL_ERROR;
>                break;
> +            case RIL.ERROR_FDN_CHECK_FAILURE:
> +              error = Ci.nsIMobileMessageCallback.FDN_CHECK_ERROR;
> +              break;

Bug 873351 has been landed to m-c.  This will need a rebase.
Attachment #800748 - Flags: review?(vyang) → review+
Will cause SMS app crashes. Backing out.
Attachment #800748 - Attachment is obsolete: true
Attachment #801567 - Flags: review+
Friendly reminder to use b2g-inbound please :)
https://hg.mozilla.org/mozilla-central/rev/682977ca05de
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.