913436 - Gecko needs to return a proper error code when sending messages to non-FDN receivers

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P1)

Description

[Gene Lian (I already quit Mozilla)]

+++ This bug was initially created as a clone of Bug #913421 +++

To satisfy the user story at Bug #913421, we need to make Gecko be able to return a proper error code like "FdnCheckError" to Gaia when users attempt to send messages to a receiver that is not in the FDN list. In this way, the users can be notified that the reason why sending SMS fails is specifically due to the FDN check error, instead of a generic error.

Comment 1

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

Waiting on the feedback at bug 913421, comment #1.

Comment 2

[Gene Lian (I already quit Mozilla)]

Comment on attachment 800748 [details] [diff] [review]
Patch

According to bug 913421, comment #2. We only need to support for SMS.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 800748 [details] [diff] [review]
Patch

Review of attachment 800748 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +3097,5 @@
>                error = Ci.nsIMobileMessageCallback.NO_SIGNAL_ERROR;
>                break;
> +            case RIL.ERROR_FDN_CHECK_FAILURE:
> +              error = Ci.nsIMobileMessageCallback.FDN_CHECK_ERROR;
> +              break;

Bug 873351 has been landed to m-c.  This will need a rebase.

Comment 4

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f377abbf13e

Comment 5

[Gene Lian (I already quit Mozilla)]

Will cause SMS app crashes. Backing out.

Comment 6

[Gene Lian (I already quit Mozilla)]

Back out: https://hg.mozilla.org/integration/mozilla-inbound/rev/5b5b2b8f57f8

Reland: https://hg.mozilla.org/integration/mozilla-inbound/rev/682977ca05de

Sorry for not updating the UUID. :(

Comment 7

[Gene Lian (I already quit Mozilla)]

Attachment: Patch (checked-in)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Friendly reminder to use b2g-inbound please :)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/682977ca05de