Closed
Bug 913462
Opened 11 years ago
Closed 11 years ago
The default "blue" collection theme should scale the collection's image to fit
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
2013-09-17
People
(Reporter: basta, Assigned: basta)
References
Details
I'd fix it myself, but I don't know enough about how the background image is treated or if we're doing any kind of 2x retina magic on it.
Reasoning: it's better to have a blurry image than something like http://cl.ly/image/360k1M0e330d
Assignee | ||
Comment 1•11 years ago
|
||
I'll let you decide which scaling technique is best. Stretched to fit, contain, cover, etc.
Updated•11 years ago
|
Blocks: mkt-publishtool-api
Comment 2•11 years ago
|
||
Let's use background-size: contain or something to make this fit more.
Priority: -- → P3
Updated•11 years ago
|
Assignee: nobody → dspasovski
Assignee | ||
Comment 3•11 years ago
|
||
I did this last week; it seems sufficient for now. We can open new bugs if there are tweaks. cvan even said that he doesn't "hate background-size:cover as much as [he] thought [he] would."
QA str:
- Upload an image in the curation tool for a collection
- Visit the collection in the consumer pages
- The image should take up the full height and width of the collection header area.
Assignee: dspasovski → mattbasta
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2013-09-17
You need to log in
before you can comment on or make changes to this bug.
Description
•