Remove support for 'moz-webgl' context requests

RESOLVED FIXED in mozilla29

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jgilbert, Assigned: emk)

Tracking

(Blocks 1 bug, {dev-doc-complete, site-compat})

unspecified
mozilla29
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

We still maintain support for retrieving a webgl context from a canvas via 'moz-webgl'. We should deprecate and then remove this.
Assignee: nobody → dglastonbury
Blocks: unprefix
Attachment #805984 - Attachment is obsolete: true
Attachment #806004 - Flags: review?(jgilbert)
Attachment #806004 - Flags: review?(bjacob)
Comment on attachment 806004 [details] [diff] [review]
fix-913597.patch

Review of attachment 806004 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, thanks. bjacob can review if he wants, but it really only needs one of us.
Attachment #806004 - Flags: review?(jgilbert)
Attachment #806004 - Flags: review?(bjacob)
Attachment #806004 - Flags: review+
Nope, that's fine :-)
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/ae31c55333b3 - from the looks of it, we must only support experimental-webgl, and not webgl, on Android, but the test was running there, so https://tbpl.mozilla.org/php/getParsedLog.php?id=28010372&tree=Mozilla-Inbound
Yep, this is true.
Restrict the test to just 'moz-webgl' and 'experimental-webgl', since we already have a test that checks 'webgl'.
Actually, probably just test that if 'experimental-webgl' succeeds, then 'moz-webgl' fails.
I'm not actively working on this.
Assignee: dglastonbury → nobody
Posted patch fix-913597.patch (obsolete) — Splinter Review
Unbitrotted and removed the test for the unprefixed context name.
Assignee: nobody → VYV03354
Attachment #806004 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8362520 - Flags: review?(jgilbert)
Attachment #8362520 - Flags: review?(jgilbert) → review+
Is WebGL totally unavailable on B2G?
WebGL is totally _available_ on B2G and even used in the Gallery application :-)
Then there should be a test preventing it from regression.
Blocks: 909903
(In reply to Benoit Jacob [:bjacob] from comment #16)
> WebGL is totally _available_ on B2G and even used in the Gallery application
> :-)

Yeah, but we have awful coverage on try. I don't remember if we successfully run any webgl on B2G at the moment.
According to bug 909903, WebGL context creation was possible until bug 900201 was fixed.
The workaround written in bug 900201 comment #19 did not work anymore.
https://tbpl.mozilla.org/?tree=Try&rev=7c9f1b59daca
We will have to disable the test on B2G atm.
Added SpecialPowers.pushPrevEnv to force-enable WebGL on B2G desktop build, and B2G check for exemption. (force-enable had no effect on B2G emulator.)

Try run: https://tbpl.mozilla.org/?tree=Try&rev=06babe90c8bc
Attachment #8362520 - Attachment is obsolete: true
Attachment #8365627 - Flags: review?(jgilbert)
Attachment #8365627 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/e9c39aa248f3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.