913597 - Remove support for 'moz-webgl' context requests

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

We still maintain support for retrieving a webgl context from a canvas via 'moz-webgl'. We should deprecate and then remove this.

Comment 1

[u480271]

Attachment: Remove support for obsolete 'moz-webgl' name for creation of WebGL contexts.

Comment 2

[u480271]

Attachment: fix-913597.patch

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 806004 [details] [diff] [review]
fix-913597.patch

Review of attachment 806004 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, thanks. bjacob can review if he wants, but it really only needs one of us.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Nope, that's fine :-)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/505e8f8480d2

Comment 6

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/ae31c55333b3 - from the looks of it, we must only support experimental-webgl, and not webgl, on Android, but the test was running there, so https://tbpl.mozilla.org/php/getParsedLog.php?id=28010372&tree=Mozilla-Inbound

Comment 7

[Phil Ringnalda (:philor)]

Oh, and b2g, which supports neither, https://tbpl.mozilla.org/php/getParsedLog.php?id=28013847&tree=Mozilla-Inbound

Comment 8

[Kelsey Gilbert [:jgilbert]]

Yep, this is true.
Restrict the test to just 'moz-webgl' and 'experimental-webgl', since we already have a test that checks 'webgl'.

Comment 9

[Kelsey Gilbert [:jgilbert]]

Actually, probably just test that if 'experimental-webgl' succeeds, then 'moz-webgl' fails.

Comment 10

[u480271]

I'm not actively working on this.

Comment 11

[Masatoshi Kimura [:emk]]

Attachment: fix-913597.patch

Unbitrotted and removed the test for the unprefixed context name.

Comment 12

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07e5bf2cb7c8

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Still failing. Backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5cf670407fac

https://tbpl.mozilla.org/php/getParsedLog.php?id=33402846&tree=Mozilla-Inbound

Comment 14

[Ryan VanderMeulen [:RyanVM]]

And regular B2G.
https://tbpl.mozilla.org/php/getParsedLog.php?id=33405111&tree=Mozilla-Inbound

Comment 15

[Masatoshi Kimura [:emk]]

Is WebGL totally unavailable on B2G?

Comment 16

[Benoit Jacob [:bjacob] (mostly away)]

WebGL is totally _available_ on B2G and even used in the Gallery application :-)

Comment 17

[Masatoshi Kimura [:emk]]

Then there should be a test preventing it from regression.

Comment 18

[Kelsey Gilbert [:jgilbert]]

(In reply to Benoit Jacob [:bjacob] from comment #16)
> WebGL is totally _available_ on B2G and even used in the Gallery application
> :-)

Yeah, but we have awful coverage on try. I don't remember if we successfully run any webgl on B2G at the moment.

Comment 19

[Masatoshi Kimura [:emk]]

According to bug 909903, WebGL context creation was possible until bug 900201 was fixed.

Comment 20

[Masatoshi Kimura [:emk]]

The workaround written in bug 900201 comment #19 did not work anymore.
https://tbpl.mozilla.org/?tree=Try&rev=7c9f1b59daca
We will have to disable the test on B2G atm.

Comment 21

[Masatoshi Kimura [:emk]]

Attachment: fix-913597.patch

Added SpecialPowers.pushPrevEnv to force-enable WebGL on B2G desktop build, and B2G check for exemption. (force-enable had no effect on B2G emulator.)

Try run: https://tbpl.mozilla.org/?tree=Try&rev=06babe90c8bc

Comment 22

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9c39aa248f3

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e9c39aa248f3

Comment 24

[Kohei Yoshino]

https://developer.mozilla.org/en-US/Firefox/Releases/29/Site_Compatibility