913614 - For lines and rectangles, skip the work when the input is invalid

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

Do a quick exit when the rectangle/line input is invalid.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Avoid work for input values that would not give us a useful result anyway. r=jmuizelaar

Jeff reviewed this offline.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

No Try link, no problem.
https://hg.mozilla.org/integration/mozilla-inbound/rev/03dbb211fd6b

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/03dbb211fd6b

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 800923 [details] [diff] [review]
Avoid work for input values that would not give us a useful result anyway. r=jmuizelaar

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
n/a
User impact if declined:
Some scenarios are wasting time.
Testing completed (on m-c, etc.):
Yes.
Risk to taking this patch (and alternatives if risky): 
Low.
String or IDL/UUID changes made by this patch:
None.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5706a9c6704a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

This depends on bug 903526 which doesn't have approval to land (nor was it ever requested?). Backed out.
https://hg.mozilla.org/releases/mozilla-aurora/rev/97e0d6a03696

Also, I assume that bug 905219 also needs uplifting if bug 903526 is?

Comment 9

[Milan Sreckovic [:milan] (needinfo for best results)]

Indeed.  Just requested uplift of bug 903526.  I will tag this as checkin-needed once the other one is taken care of.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/691c5a00acd2

Comment 11

[u279076]

Assuming no verification needed here. Please add the verifyme keyword and remove the [qa-] whiteboard tag to request verification.

Comment 12

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/releases/mozilla-esr24/rev/b6aa22c418f4

Comment 13

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/releases/mozilla-esr17/rev/eeab87c4c2db