913647 - Deploy YUI 3.17.2 for BMO

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect, P1)

Description

[David Lawrence [:dkl]]

YUI 3.12.0 is out and we should update the version of YUI installed with BMO to bring in bug fixes such as bfcache.

dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: 913647_1.patch

need sanity check on your system using the dashboards, component search, etc.

I have pushed it to bugzilla-dev as well for sanity testing.

Committing to: bzr+ssh://[e-mail]/bmo/4.2-dev
[lots of stuff]
Committed revision 8550.

dkl

Comment 2

[:glob ✱]

Comment on attachment 804496 [details] [diff] [review]
913647_1.patch

i get the following error on enter_bug, and both dashboards, rendering them non-functional:

TypeError: e.AttributeObservable is undefined attribute-base-min.js:8

Comment 3

[David Lawrence [:dkl]]

(In reply to Byron Jones ‹:glob› from comment #2)
> Comment on attachment 804496 [details] [diff] [review]
> 913647_1.patch
> 
> i get the following error on enter_bug, and both dashboards, rendering them
> non-functional:
> 
> TypeError: e.AttributeObservable is undefined attribute-base-min.js:8

Reverted for now til I have more time to work on this.

dkl

Comment 4

[Dylan Hardison [:dylan] (he/him)]

I haven't noticed any problem running MyDashboard or Product Dashboard locally, so I will push the YUI 3.17.2 code up to bugzilla-dev today and get more eyeballs looking for regressions.

Comment 5

[Mark Côté [:mcote]]

I played around a bit and didn't notice any issues.  Go ahead post a patch.

Comment 6

[David Lawrence [:dkl]]

(In reply to Mark Côté ( :mcote ) from comment #5)
> I played around a bit and didn't notice any issues.  Go ahead post a patch.

I also did not see any issues. I am not sure that a patch of a YUI update is worthwhile as it will be likely very large, minimized, and we won't be able to review it anyway.

Dylan, I assume you used the contrib/new-yui3.pl script to install the files with? It does quite a bit of cleanup and other stuff.

Unless glob has any objection, we should just skip the review and commit as long as it is installed the same as the previous version.

dkl

Comment 7

[Dylan Hardison [:dylan] (he/him)]

dkl: Yep, I used the script.

Comment 8

[Dylan Hardison [:dylan] (he/him)]

Attachment: bug-913647-v2.patch

For review

Comment 9

[:glob ✱]

Comment on attachment 8470872 [details] [diff] [review]
bug-913647-v2.patch

r=glob ship it

Comment 10

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   14be79f..bd23fbf  master -> master