Closed Bug 913647 Opened 7 years ago Closed 5 years ago

Deploy YUI 3.17.2 for BMO

Categories

(bugzilla.mozilla.org :: General, defect, P1)

Production
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: dkl, Assigned: dylan)

References

Details

Attachments

(1 file, 1 obsolete file)

YUI 3.12.0 is out and we should update the version of YUI installed with BMO to bring in bug fixes such as bfcache.

dkl
Attached patch 913647_1.patch (obsolete) — Splinter Review
need sanity check on your system using the dashboards, component search, etc.

I have pushed it to bugzilla-dev as well for sanity testing.

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2-dev
[lots of stuff]
Committed revision 8550.

dkl
Attachment #804496 - Flags: feedback?(glob)
Comment on attachment 804496 [details] [diff] [review]
913647_1.patch

i get the following error on enter_bug, and both dashboards, rendering them non-functional:

TypeError: e.AttributeObservable is undefined attribute-base-min.js:8
Attachment #804496 - Flags: feedback?(glob) → feedback-
(In reply to Byron Jones ‹:glob› from comment #2)
> Comment on attachment 804496 [details] [diff] [review]
> 913647_1.patch
> 
> i get the following error on enter_bug, and both dashboards, rendering them
> non-functional:
> 
> TypeError: e.AttributeObservable is undefined attribute-base-min.js:8

Reverted for now til I have more time to work on this.

dkl
Assignee: dkl → dylan
Summary: Deploy YUI 3.12.0 for BMO → Deploy YUI 3.17.1 for BMO
Summary: Deploy YUI 3.17.1 for BMO → Deploy YUI 3.17.2 for BMO
I haven't noticed any problem running MyDashboard or Product Dashboard locally, so I will push the YUI 3.17.2 code up to bugzilla-dev today and get more eyeballs looking for regressions.
Blocks: 1021902
I played around a bit and didn't notice any issues.  Go ahead post a patch.
(In reply to Mark Côté ( :mcote ) from comment #5)
> I played around a bit and didn't notice any issues.  Go ahead post a patch.

I also did not see any issues. I am not sure that a patch of a YUI update is worthwhile as it will be likely very large, minimized, and we won't be able to review it anyway.

Dylan, I assume you used the contrib/new-yui3.pl script to install the files with? It does quite a bit of cleanup and other stuff.

Unless glob has any objection, we should just skip the review and commit as long as it is installed the same as the previous version.

dkl
dkl: Yep, I used the script.
For review
Attachment #8470872 - Flags: review?(glob)
Priority: -- → P1
Attachment #804496 - Attachment is obsolete: true
Comment on attachment 8470872 [details] [diff] [review]
bug-913647-v2.patch

r=glob ship it
Attachment #8470872 - Flags: review?(glob) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   14be79f..bd23fbf  master -> master
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.