Closed Bug 913751 Opened 13 years ago Closed 11 years ago

Location Bar autocompletion for bookmarks using asterisk does not work for bookmarklets

Categories

(Firefox :: Bookmarks & History, defect)

23 Branch
x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: bgoodr, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release) Build ID: 20130814063812 Steps to reproduce: Add a bookmark with these attributes: Name: GitHub Help Location: https://help.github.com/ Then type CTRL-L. Then type: git * (notice the space after the t and before the *) You should see the completion list include GitHub Help in the list. That is expected. Now change the bookmark to have these attributes instead: Name: GitHub Help Location: javascript:(function()%20alert('some_error_here'))%20(); Then type CTRL-L. Then type: git * Actual results: You should see the completion list include GitHub Help in the list. But it does not. Expected results: It should not matter what the content is of the URL. The completion results should list it.
Component: Untriaged → Bookmarks & History
Reproducible with the latest Nightly (build ID: 20130908030205) on Ubuntu 12.10 32bit.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Irritating. I don't want to memorize all the keywords for bookmarklets I have bookmarked.
bookmarklets aren't suggested in the location bar at all (regardless of whether the user types an asterisk, which I've never heard of doing until now).
(In reply to Adeline from comment #3) > bookmarklets aren't suggested in the location bar at all (regardless of > whether the user types an asterisk, which I've never heard of doing until > now). The * is a modifier, see eg http://alicious.com/fast-bookmark-and-history-search-in-firefox/ (my own blog).
I have this problem too - I want to use a bookmarklet but the awesomebar will only pick it up when I type "javascript:" (without quotes). As soon as the colon goes in the bookmarklet appears first in the list, up to then no bookmarklets are shown at all. Why bookmarklets are ignored if you tag them and then search on a tag is beyond me really. Unfortunately this bug, https://bugzilla.mozilla.org/show_bug.cgi?id=416904, suggests that this is by design??
Yes, unfortunately for security reasons we don't allow to search for bookmarklets unless javascript: is typed in the locationbar explicitly. On the other side it's easy to keep them in a bookmark folder on the toolbar/menu.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Marco, could we please get an about:config preference for this? Not everyone wants the bookmarks bar. Besides, what security rationale differentiates between bookmarklets activated from the bookmarks bar vs ones activated through the location bar? The user either understands the implications of selecting a bookmarklet or they don't; I don't see how this protects the user at all.
Flags: needinfo?(mak77)
did you try setting browser.urlbar.filter.javascript to false?
Flags: needinfo?(mak77)
Thanks, Marco, that works perfectly.
Setting browser.urlbar.filter.javascript to false works for me too (Firefox version 42.0). I would consider this bug fixed then. Thanks Marco!
You need to log in before you can comment on or make changes to this bug.