BindingUtils.h doesn't need to include <algorithm>

RESOLVED FIXED in mozilla27

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla27
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 801150 [details] [diff] [review]
Do the min by hand

It seems to be including <algorithm> only for one single usage of std::min. Given how critical this header is, it seems worth doing the min by hand.
Attachment #801150 - Flags: review?(ehsan)
(Assignee)

Comment 1

5 years ago
Created attachment 801151 [details] [diff] [review]
Do the min by hand
Attachment #801150 - Attachment is obsolete: true
Attachment #801150 - Flags: review?(ehsan)
Attachment #801151 - Flags: review?(ehsan)
(Assignee)

Updated

5 years ago
Blocks: 913869

Updated

5 years ago
Attachment #801151 - Flags: review?(ehsan) → review?(bzbarsky)
Attachment #801151 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d4c51537450
Assignee: nobody → bjacob
Target Milestone: --- → mozilla27
https://hg.mozilla.org/mozilla-central/rev/6d4c51537450
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Blocks: 785103
You need to log in before you can comment on or make changes to this bug.