Closed Bug 913881 Opened 12 years ago Closed 12 years ago

More misc. cycle collector cleanups

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(6 files)

More misc. cycle collector cleanups I came across while working on ICC, but not directly related to it.
Blocks: 913666
Depends on: 913527
Comment on attachment 801670 [details] [diff] [review] part 6 - Measure weak map representations in the cycle collector graph. r=njn Review of attachment 801670 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/base/nsCycleCollector.cpp @@ -611,5 @@ > *aNodesSize = mNodes.SizeOfExcludingThis(aMallocSizeOf); > *aEdgesSize = mEdges.SizeOfExcludingThis(aMallocSizeOf); > - > - // These fields are deliberately not measured: > - // - mWeakMaps entries, because the pointers are non-owning This comment still holds, right? So the comment could be kept, maybe with modification, something like: "We don't measure what the mWeakMaps entries point to, because the pointers are non-owning." @@ +2819,2 @@ > size_t *aWhiteNodeSize, > size_t *aPurpleBufferSize) const We should make a struct for this. But it doesn't have to be now.
Attachment #801670 - Flags: review?(n.nethercote) → review+
Comment on attachment 801669 [details] [diff] [review] part 5 - Assert for freeing snow white during cycle collector scanning. r=smaug Could you change the comment. It is not right in case aAsyncSnowWhiteFreeing is false. Maybe, "Don't forget skippable or free snow-white while scan is in progress."
Attachment #801669 - Flags: review?(bugs) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: