Closed
Bug 913881
Opened 12 years ago
Closed 12 years ago
More misc. cycle collector cleanups
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(6 files)
895 bytes,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
3.74 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
2.05 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
2.25 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
1.15 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
5.84 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
More misc. cycle collector cleanups I came across while working on ICC, but not directly related to it.
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Comment 1•12 years ago
|
||
single platform try run: https://tbpl.mozilla.org/?tree=Try&rev=633297ed2418
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #801665 -
Flags: review?(bugs)
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #801666 -
Flags: review?(bugs)
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #801667 -
Flags: review?(bugs)
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #801668 -
Flags: review?(bugs)
Assignee | ||
Comment 6•12 years ago
|
||
Attachment #801669 -
Flags: review?(bugs)
Assignee | ||
Comment 7•12 years ago
|
||
Attachment #801670 -
Flags: review?(n.nethercote)
![]() |
||
Comment 8•12 years ago
|
||
Comment on attachment 801670 [details] [diff] [review]
part 6 - Measure weak map representations in the cycle collector graph. r=njn
Review of attachment 801670 [details] [diff] [review]:
-----------------------------------------------------------------
::: xpcom/base/nsCycleCollector.cpp
@@ -611,5 @@
> *aNodesSize = mNodes.SizeOfExcludingThis(aMallocSizeOf);
> *aEdgesSize = mEdges.SizeOfExcludingThis(aMallocSizeOf);
> -
> - // These fields are deliberately not measured:
> - // - mWeakMaps entries, because the pointers are non-owning
This comment still holds, right? So the comment could be kept, maybe with modification, something like: "We don't measure what the mWeakMaps entries point to, because the pointers are non-owning."
@@ +2819,2 @@
> size_t *aWhiteNodeSize,
> size_t *aPurpleBufferSize) const
We should make a struct for this. But it doesn't have to be now.
Attachment #801670 -
Flags: review?(n.nethercote) → review+
Attachment #801665 -
Flags: review?(bugs) → review+
Attachment #801666 -
Flags: review?(bugs) → review+
Attachment #801667 -
Flags: review?(bugs) → review+
Attachment #801668 -
Flags: review?(bugs) → review+
Comment on attachment 801669 [details] [diff] [review]
part 5 - Assert for freeing snow white during cycle collector scanning. r=smaug
Could you change the comment. It is not right in case
aAsyncSnowWhiteFreeing is false.
Maybe, "Don't forget skippable or free snow-white while scan is in progress."
Attachment #801669 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 10•12 years ago
|
||
Thanks, I addressed the review comments. I filed bug 914698 for using structs for the memory reporter arguments.
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/431aa2871160
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/50f93200b176
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/8ac551efe4e1
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/d722282fdc4d
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/a36c944c929e
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/fb46afe7f48b
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/431aa2871160
https://hg.mozilla.org/mozilla-central/rev/50f93200b176
https://hg.mozilla.org/mozilla-central/rev/8ac551efe4e1
https://hg.mozilla.org/mozilla-central/rev/d722282fdc4d
https://hg.mozilla.org/mozilla-central/rev/a36c944c929e
https://hg.mozilla.org/mozilla-central/rev/fb46afe7f48b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•