913923 - Stop including BindingUtils.h in UnionTypes.h

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: Move UnionMember into its own header;

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Move OwningNonNull into its own header;

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part c: Stop including BindingUtils.h in UnionTypes.h;

Comment 4

[David Zbarsky (:dzbarsky)]

Comment on attachment 801427 [details] [diff] [review]
Part a: Move UnionMember into its own header;

Review of attachment 801427 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/UnionMember.h
@@ +2,5 @@
> +/* vim: set ts=8 sts=2 et sw=2 tw=80: */
> +/* This Source Code Form is subject to the terms of the Mozilla Public
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +

Can you hg cp this?

Comment 5

[David Zbarsky (:dzbarsky)]

Comment on attachment 801428 [details] [diff] [review]
Part b: Move OwningNonNull into its own header;

Review of attachment 801428 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsDOMMutationObserver.cpp
@@ +3,5 @@
>  /* This Source Code Form is subject to the terms of the Mozilla Public
>   * License, v. 2.0. If a copy of the MPL was not distributed with this file,
>   * You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  #include "nsDOMMutationObserver.h"        

delete whitespace while you're here?

::: dom/bindings/OwningNonNull.h
@@ +2,5 @@
> +/* vim: set ts=8 sts=2 et sw=2 tw=80: */
> +/* This Source Code Form is subject to the terms of the Mozilla Public
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +

hg cp

Comment 6

[David Zbarsky (:dzbarsky)]

Comment on attachment 801429 [details] [diff] [review]
Part c: Stop including BindingUtils.h in UnionTypes.h;

Review of attachment 801429 [details] [diff] [review]:
-----------------------------------------------------------------

Does this patch actually help?  We shouldn't be including UnionTypes.h in any headers!

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to David Zbarsky (:dzbarsky) from comment #6)
> Comment on attachment 801429 [details] [diff] [review]
> Part c: Stop including BindingUtils.h in UnionTypes.h;
> 
> Review of attachment 801429 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Does this patch actually help?  We shouldn't be including UnionTypes.h in
> any headers!

We do in HTMLOptionsCollection.h (which we should probably fix regardless). However, I still think it's useful to avoid having to include BindingUtils.h at all outside of dom/bindings/.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/e73983f4a108
https://hg.mozilla.org/mozilla-central/rev/c762fde381a8
https://hg.mozilla.org/mozilla-central/rev/e6a8b40cb9bd