Closed Bug 913923 Opened 6 years ago Closed 6 years ago

Stop including BindingUtils.h in UnionTypes.h

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

No description provided.
Comment on attachment 801427 [details] [diff] [review]
Part a: Move UnionMember into its own header;

Review of attachment 801427 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/UnionMember.h
@@ +2,5 @@
> +/* vim: set ts=8 sts=2 et sw=2 tw=80: */
> +/* This Source Code Form is subject to the terms of the Mozilla Public
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +

Can you hg cp this?
Attachment #801427 - Flags: review?(dzbarsky) → review+
Comment on attachment 801428 [details] [diff] [review]
Part b: Move OwningNonNull into its own header;

Review of attachment 801428 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsDOMMutationObserver.cpp
@@ +3,5 @@
>  /* This Source Code Form is subject to the terms of the Mozilla Public
>   * License, v. 2.0. If a copy of the MPL was not distributed with this file,
>   * You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  #include "nsDOMMutationObserver.h"        

delete whitespace while you're here?

::: dom/bindings/OwningNonNull.h
@@ +2,5 @@
> +/* vim: set ts=8 sts=2 et sw=2 tw=80: */
> +/* This Source Code Form is subject to the terms of the Mozilla Public
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +

hg cp
Attachment #801428 - Flags: review?(dzbarsky) → review+
Comment on attachment 801429 [details] [diff] [review]
Part c: Stop including BindingUtils.h in UnionTypes.h;

Review of attachment 801429 [details] [diff] [review]:
-----------------------------------------------------------------

Does this patch actually help?  We shouldn't be including UnionTypes.h in any headers!
Attachment #801429 - Flags: review?(dzbarsky) → review+
(In reply to David Zbarsky (:dzbarsky) from comment #6)
> Comment on attachment 801429 [details] [diff] [review]
> Part c: Stop including BindingUtils.h in UnionTypes.h;
> 
> Review of attachment 801429 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Does this patch actually help?  We shouldn't be including UnionTypes.h in
> any headers!

We do in HTMLOptionsCollection.h (which we should probably fix regardless). However, I still think it's useful to avoid having to include BindingUtils.h at all outside of dom/bindings/.
https://hg.mozilla.org/mozilla-central/rev/e73983f4a108
https://hg.mozilla.org/mozilla-central/rev/c762fde381a8
https://hg.mozilla.org/mozilla-central/rev/e6a8b40cb9bd
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.