Closed Bug 913946 Opened 6 years ago Closed 6 years ago

Add emulator-jb to trychooser

Categories

(Release Engineering :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philor, Assigned: philor)

References

Details

(Keywords: trychooser)

Attachments

(1 file)

Attached patch [tools] add itSplinter Review
Much as we all love things that people can only figure out how to run with -p all...
Attachment #801278 - Flags: review?(emorley)
Comment on attachment 801278 [details] [diff] [review]
[tools] add it

Review of attachment 801278 [details] [diff] [review]:
-----------------------------------------------------------------

::: trychooser/index.html
@@ +98,5 @@
>                  <span id="test_android-x86" class="test_queue">N/A</span>
>                  <span id="build_android-x86" class="build_queue">N/A</span>
>              </li>
>              <li>
> +                <label><input type="checkbox" name="platform" value="emulator" data-project="b2g">emulator (B2G arm, ICS)</label>

I know this was pre-existing, but could you capitalise ARM whilst you're here please? :-)
Attachment #801278 - Flags: review?(emorley) → review+
Comment on attachment 801278 [details] [diff] [review]
[tools] add it

https://hg.mozilla.org/build/tools/rev/a88168327289

I was tempted to use aRM for one and arM for the other, those being the last two capitalization permutations we don't already use, but I resisted.
Attachment #801278 - Flags: checked-in+
Keywords: trychooser
Depends on: 919331
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Tools → General
You need to log in before you can comment on or make changes to this bug.