Setup b2g gonk-JB emulator builds for v1.2

RESOLVED FIXED

Status

Release Engineering
General Automation
--
major
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: mwu, Assigned: catlee)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(7 attachments, 4 obsolete attachments)

170 bytes, text/html
mwu
: review+
Details
183 bytes, text/html
mwu
: review+
Details
427 bytes, text/html
mwu
: review+
Details
2.61 KB, patch
mwu
: review+
Details | Diff | Splinter Review
1.75 KB, patch
aki
: review+
Details | Diff | Splinter Review
5.21 KB, patch
aki
: review+
catlee
: checked-in+
Details | Diff | Splinter Review
13.37 KB, patch
aki
: review+
Details | Diff | Splinter Review
(Reporter)

Description

5 years ago
The 1.2 release will be based on gonk-JB. We want to make jb emulator builds in order to make sure people don't break the build. We'll also want tests at some point, but builds are a good first start. We'll want this running on m-c/m-i/birch.

Support for this isn't fully landed yet, but I'll post here once it's ready.
found in triage
Component: Release Engineering → Release Engineering: Automation (General)
QA Contact: catlee
Summary: Add gonk-JB emulator builds → Setup b2g gonk-JB emulator builds for v1.2
(Reporter)

Comment 2

5 years ago
The gonk-jb emulator is now available.

BRANCH=master ./config.sh emulator-jb && ./build.sh
Severity: normal → major
Created attachment 771973 [details]
Github PR for manifest

With changes in external/qemu, hardware/ril, devices/generic/goldfish merged, emulator test cases runs with JB Gonk!
Attachment #771973 - Flags: review?(mwu)
Created attachment 771974 [details]
Github PR for hardware/ril

In hardware/ril, ICS and JB share the same HEAD currently, so this PR is for master branch.
Attachment #771974 - Flags: review?(mwu)
Created attachment 771975 [details]
Github PR for device/generic/goldfish

This PR is basically merging current b2g master branch HEAD into a new branch named "b2g-4.2.2_r1".
Attachment #771975 - Flags: review?(mwu)
There is already a merge branch named "b2g-4.2.2_r1" waiting for JB Gonk in external/qemu.  See https://github.com/mozilla-b2g/platform_external_qemu/tree/b2g-4.2.2_r1 .  It's simply renamed from "next/jb-mr1-release" branch.
Attachment #771975 - Attachment is obsolete: true
Attachment #771975 - Flags: review?(mwu)
(Reporter)

Comment 7

4 years ago
Comment on attachment 771974 [details]
Github PR for hardware/ril

Merged. I would prefer a different bug next time though, as this bug is a releng bug just to make gonk-jb builds. It does not require successful test runs.
Attachment #771974 - Flags: review?(mwu) → review+
Blocks: 891217
No longer blocks: 891217
(Reporter)

Comment 8

4 years ago
Comment on attachment 771973 [details]
Github PR for manifest

Merged
Attachment #771973 - Flags: review?(mwu) → review+
(Assignee)

Comment 9

4 years ago
do we need debug builds as well?
(Assignee)

Updated

4 years ago
Assignee: nobody → catlee
(Assignee)

Comment 10

4 years ago
Is there a reason the name for the "gecko.git" repo has been changed to be "mozilla-central" for the base-jb.xml manifest? 

https://github.com/mozilla-b2g/b2g-manifest/blob/master/base-jb.xml#L13

This is breaking our build scripts, which currently assume that the gecko repo is named "gecko.git" in the manifest.
(Assignee)

Comment 11

4 years ago
Also, is there a reason why the manifests point to the AOSP mirrors rather than CAF for projects like platform/abi/cpp, platform/bionic and platform/bootable/recovery?
Product: mozilla.org → Release Engineering
(Assignee)

Comment 12

4 years ago
Created attachment 790314 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/b2g-manifest/pull/91#attch-to-bugzilla

Pointer to Github pull-request
(Assignee)

Updated

4 years ago
Attachment #790314 - Flags: review?(mwu)
(Reporter)

Comment 13

4 years ago
Comment on attachment 790314 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/b2g-manifest/pull/91#attch-to-bugzilla

Looks good. If you don't mind, please do an interactive rebase and squash everything into one commit before merging.
Attachment #790314 - Flags: review?(mwu) → review+
(Assignee)

Comment 14

4 years ago
Looks like the github PR got merged as-is.
(Assignee)

Updated

4 years ago
Depends on: 907334
(Assignee)

Updated

4 years ago
Depends on: 907445
(Assignee)

Comment 15

4 years ago
Created attachment 794672 [details] [diff] [review]
master-b2g-manifest.diff

Two small follow up issues.

First, we need to change gaia's remote to be mozilla like for gecko.

Second, CAF's mirror of icu4c is missing the android-4.3_r2.1 tag for some reason. All the other repositories seem to have it. We can pull just this repo from aosp (or linaro) and start mirroring it from aosp. Alternatively, it appears as though the linaro mirror of icu4c does have the correct tag, and we already have that mirrored, so we could use that instead.
Attachment #794672 - Flags: review?(mwu)
(Reporter)

Comment 16

4 years ago
Comment on attachment 794672 [details] [diff] [review]
master-b2g-manifest.diff

Review of attachment 794672 [details] [diff] [review]:
-----------------------------------------------------------------

::: base-jb.xml
@@ +56,5 @@
>    <project name="platform/external/giflib" path="external/giflib"/>
>    <project name="platform/external/gtest" path="external/gtest"/>
>    <project name="platform/external/harfbuzz" path="external/harfbuzz"/>
>    <project name="platform/external/harfbuzz_ng" path="external/harfbuzz_ng"/>
> +  <project name="platform/external/icu4c" path="external/icu4c" remote="aosp"/>

Let's not change remotes here. Just point to the same commit that the android-4.3_r2.1 tag points to.
(Assignee)

Comment 17

4 years ago
Created attachment 794784 [details] [diff] [review]
move gaia to git.mozilla.org; force icu4c's revision
Attachment #794672 - Attachment is obsolete: true
Attachment #794672 - Flags: review?(mwu)
Attachment #794784 - Flags: review?(mwu)
(Reporter)

Updated

4 years ago
Attachment #794784 - Flags: review?(mwu) → review+
(Reporter)

Updated

4 years ago
Depends on: 908964
(Assignee)

Comment 18

4 years ago
Status update: new manifests look like they're working well. I was running into issues last week because of missing build dependencies for libsuspend.

Seem to have gotten past that now, but now builds are failing because of xmllint being missing.
(Assignee)

Comment 19

4 years ago
...and now busted again because of new base-jb.xml manifest :\
(Assignee)

Updated

4 years ago
Depends on: 909794
(Assignee)

Comment 20

4 years ago
Created attachment 796284 [details] [diff] [review]
gecko configs for emulator-jb
Attachment #796284 - Flags: review?(aki)
(Assignee)

Comment 21

4 years ago
Created attachment 796287 [details] [diff] [review]
remove gecko/gaia from manifest by path rather than by name

the base-jb.xml manifest uses name="gaia" for gaia, whereas other manifest use name="gaia.git". Rather than forcing all manifests to use consistent naming, I change b2g_build to look at the target path on disk, and remove projects from the manifest based on that.
Attachment #796287 - Flags: review?(aki)
Attachment #796284 - Flags: review?(aki) → review+
Attachment #796287 - Flags: review?(aki) → review+
(Assignee)

Comment 22

4 years ago
Created attachment 796707 [details] [diff] [review]
gecko configs for emulator-jb

same as before except the addition of "upload_platform"
Attachment #796284 - Attachment is obsolete: true
Attachment #796707 - Flags: review?(aki)
(Assignee)

Comment 23

4 years ago
Created attachment 796709 [details] [diff] [review]
remove gecko/gaia from manifest by path rather than by name; use upload_platform for manifest upload

same as before, except I modified upload_source_manifest to obey the gecko config's upload_platform
Attachment #796287 - Attachment is obsolete: true
Attachment #796709 - Flags: review?(aki)
(Assignee)

Comment 24

4 years ago
Created attachment 796711 [details] [diff] [review]
buildbot-configs for emulator-jb
Attachment #796711 - Flags: review?(aki)
Attachment #796707 - Flags: review?(aki) → review+
Attachment #796709 - Flags: review?(aki) → review+
Attachment #796711 - Flags: review?(aki) → review+
(Assignee)

Updated

4 years ago
Attachment #796709 - Flags: checked-in+
(Assignee)

Updated

4 years ago
Whiteboard: [leave open]
https://hg.mozilla.org/mozilla-central/rev/540c53908079
In production.
(Assignee)

Updated

4 years ago
Depends on: 911203
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
Blocks: 912249

Comment 27

4 years ago
Merged to production branch. Live in production.
Depends on: 913946
Depends on: 917621

Updated

4 years ago
blocking-b2g: koi? → ---
You need to log in before you can comment on or make changes to this bug.