913952 - contacts arabic layout design has serious issues

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[leandro]

Attachment: 2013-09-08-18-43-19.2.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130903162616

Steps to reproduce:

select arabic language and go to import contacts from gmail


Actual results:

* i has a huge padding on left of the text
* it lacks padding on right side
* "search" in arabic is in the wrong place (right instead of left) and over the pagination
* "import" in arabic on the title lacks of padding and it is over the back button
* the back button lacks of text nor icon



Expected results:

* right padding in left and in right sides
* "search" in arabic must be at left near the icon
* "import" title should have paddding and not to be over the back button

Comment 1

[Jose Manuel Cantera]

I agree there are serious flaws. I don't think there are arabic countries in the next FFOS deployments, but that's something to be fixed sooner or later. 

Ismael, Arnau, any ideas?

thanks

Comment 2

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

As RTL was not a priority, we have not put much effort in current BB. But is something we are trying to improve on new BB.

Comment 3

[leandro]

So, if arabic is not a priority and the phones are not intended for arabic countries why offer arabic support?
doing nothing is better than doing it bad, isn't it?

Comment 4

[Ismael Gonzalez [:basiclines]]

Leandro, we trying our best with this issue, as Arnau said, we are developing a new version of the Building Blocks that will support RTL languages.

But hey, this is open source, you can always try to make a Pull Request from Github with the needed changes isn't it?
https://github.com/mozilla-b2g/gaia/pull/new/master

Comment 5

[leandro]

ok Ismael i didn't want to bother, i just like to ask.
by now i already do all the pull request i can in other projects :-) perhaps in the future

Comment 6

[Stephany Wilkes]

I'm adding an update here based on the 2.1 build.

* Text on buttons in Contacts should not overlap the dropdown arrows on buttons.

* Default text in Contacts fields should be aligned right. Today it is aligned left. 

* We should add a third name field to be shown when Arabic, Farsi or Urdu (forthcoming) are selected. Arabic names are usually comprised of three: the individual's name, their father's name, their grandfather's name. This will need UX so I'm flagging Carrie to see if she has time to add a name field.

* The Contacts list (not individual contact) should be able to handle and display multiple scripts (this is probably worth being a separate bug and may require platform support). A contact list for any Middle Eastern user may contain multiple scripts -- they may have contacts in (predominantly) RTL Arabic, Farsi, Urdu, etc., but might also have contacts in French or English. With countries of diverse makeup such as the UAE, Oman, etc., the contacts list could have South Asian scripts or Southeast Asian or just about anything else, so we should support this use case.

* Text input in Contacts fields is not RTL when Arabic language is selected and it should be.

* The "x" to delete/clear input text is not aligned right and it should be.

Comment 7

[Stephany Wilkes]

Also flagging Pavel since he's helping on some of this for 2.1.

Comment 8

[Ahmed Nefzaoui [:Nefzaoui]]

I think then this should become a meta bug and separate the work into RTL'ing part and another for the implementation of the 3rd/middle name and its interactions with the contacts database (and probably tests?)
??

Comment 9

[Ahmed Nefzaoui [:Nefzaoui]]

Also from what I understand, this feature will be used with certain locales (e.g. Arabic, Farsi) and not with certain layout directions (e.g. RTL) the system takes?
If so we should have a well-defined list.
I'm assuming that apart from Arabic there is Farsi and Urdu only, as you mentioned, that will need such addition?

Comment 10

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I agree with Ahmed,
and we need to open small bugs for this.

Comment 11

[Stephany Wilkes]

Attachment: 2014-08-07-17-37-00.png

Comment 12

[Stephany Wilkes]

Added screenshot to indicate that individual contact layout appears improved in 2.1.

Comment 13

[Stephany Wilkes]

Also resolving this to make smaller, more focused bugs and assign them.

Comment 14

[Peter Bylenga [:PBylenga]]

Mass Edit: adding the [rtl-meta]