Remove more dead Chromium code

RESOLVED FIXED in mozilla26

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla26
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(28 attachments)

5.32 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
2.56 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
1.98 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
5.56 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
3.79 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
9.35 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
3.32 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
11.18 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
6.69 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
5.43 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
4.41 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
1.46 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
2.75 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
2.21 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
2.24 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
2.14 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
1.29 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
2.72 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
2.62 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
4.72 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
2.42 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
4.44 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
3.49 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
2.37 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
3.99 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
2.11 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
2.40 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
2.48 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
 ipc/chromium/moz.build                              |    1 -
 ipc/chromium/src/base/foundation_utils_mac.h        |   37 ---------
 ipc/chromium/src/base/mac_util.h                    |   24 ------
 ipc/chromium/src/base/mac_util.mm                   |   35 ---------
 ipc/chromium/src/base/process.h                     |   14 ---
 ipc/chromium/src/base/process_posix.cc              |   10 --
 ipc/chromium/src/base/process_util.h                |  110 ----------------------------
 ipc/chromium/src/base/process_util_posix.cc         |  155 ---------------------------------------
 ipc/chromium/src/base/process_util_win.cc           |  308 -------------------------------------------------------------------------------
 ipc/chromium/src/base/process_win.cc                |   63 ----------------
 ipc/chromium/src/base/string_escape.cc              |   98 -------------------------
 ipc/chromium/src/base/string_escape.h               |   35 ---------
 ipc/chromium/src/base/string_util.h                 |   31 -------
 ipc/chromium/src/base/sys_string_conversions.h      |   38 ---------
 ipc/chromium/src/base/sys_string_conversions_mac.mm |   52 -------------
 ipc/chromium/src/base/win_util.cc                   |  346 -----------------------------------------------------------------------------------------
 ipc/chromium/src/base/win_util.h                    |   71 ------------------
 ipc/chromium/src/chrome/common/child_process_info.h |    1 -
 18 files changed, 0 insertions(+), 1429 deletions(-)

https://tbpl.mozilla.org/?tree=Try&rev=9b46a16ece55
(Assignee)

Comment 2

6 years ago
Created attachment 801432 [details] [diff] [review]
Part a: Remove unused JavascriptDoubleQuote functions;
Attachment #801432 - Flags: review?(ehsan)
(Assignee)

Comment 3

6 years ago
Created attachment 801433 [details] [diff] [review]
Part b: Remove unused override app bundle code;
Attachment #801433 - Flags: review?(ehsan)
(Assignee)

Comment 4

6 years ago
Created attachment 801434 [details] [diff] [review]
Part c: Remove unused FSRef code;
Attachment #801434 - Flags: review?(ehsan)
(Assignee)

Comment 5

6 years ago
Created attachment 801435 [details] [diff] [review]
Part d: Remove unused conversion code to CFStringRef and NSString;
Attachment #801435 - Flags: review?(ehsan)
(Assignee)

Comment 6

6 years ago
Created attachment 801436 [details] [diff] [review]
Part e: Remove unused conversion code from CFStringRef and NSString;
Attachment #801436 - Flags: review?(ehsan)
(Assignee)

Comment 7

6 years ago
Created attachment 801437 [details] [diff] [review]
Part f: Remove unused process cleanup code;
Attachment #801437 - Flags: review?(ehsan)
(Assignee)

Comment 8

6 years ago
Created attachment 801439 [details] [diff] [review]
Part g: Remove unused GetProcessCount function;
Attachment #801439 - Flags: review?(ehsan)
(Assignee)

Comment 9

6 years ago
Created attachment 801440 [details] [diff] [review]
Part h: Remove unused WaitForExitCode and GetAppOutput functions;
Attachment #801440 - Flags: review?(ehsan)
(Assignee)

Comment 10

6 years ago
Created attachment 801441 [details] [diff] [review]
Part i: Remove unused ReduceWorkingSet and UnReduceWorkingSet functions;
Attachment #801441 - Flags: review?(ehsan)
(Assignee)

Comment 11

6 years ago
Created attachment 801442 [details] [diff] [review]
Part j: Remove unused GetWorkingSetKBytes function;
Attachment #801442 - Flags: review?(ehsan)
(Assignee)

Comment 12

6 years ago
Created attachment 801443 [details] [diff] [review]
Part k: Remove unused GetCommittedKBytes function;
Attachment #801443 - Flags: review?(ehsan)
(Assignee)

Comment 13

6 years ago
Created attachment 801444 [details] [diff] [review]
Part l: Remove unused FreeMBytes struct;
Attachment #801444 - Flags: review?(ehsan)
(Assignee)

Comment 14

6 years ago
Created attachment 801445 [details] [diff] [review]
Part m: Remove unused GetPrivateBytes function;
Attachment #801445 - Flags: review?(ehsan)
(Assignee)

Comment 15

6 years ago
Created attachment 801446 [details] [diff] [review]
Part n: Remove unused GetWorkingSetSize function;
Attachment #801446 - Flags: review?(ehsan)
(Assignee)

Comment 16

6 years ago
Created attachment 801447 [details] [diff] [review]
Part o: Remove unused GetPeakPagefileUsage function;
Attachment #801447 - Flags: review?(ehsan)
(Assignee)

Comment 17

6 years ago
Created attachment 801448 [details] [diff] [review]
Part p: Remove unused GetPagefileUsage function;
Attachment #801448 - Flags: review?(ehsan)
(Assignee)

Comment 18

6 years ago
Created attachment 801449 [details] [diff] [review]
Part q: Remove unused MatchPattern function;
Attachment #801449 - Flags: review?(ehsan)
(Assignee)

Comment 19

6 years ago
Created attachment 801450 [details] [diff] [review]
Part r: Remove unused GetClassName function;
Attachment #801450 - Flags: review?(ehsan)
(Assignee)

Comment 20

6 years ago
Created attachment 801451 [details] [diff] [review]
Part s: Remove unused UserAccountControlIsEnabled function;
Attachment #801451 - Flags: review?(ehsan)
(Assignee)

Comment 21

6 years ago
Created attachment 801452 [details] [diff] [review]
Part t: Remove unused HWND creation/destruction functions;
Attachment #801452 - Flags: review?(ehsan)
(Assignee)

Comment 22

6 years ago
Created attachment 801453 [details] [diff] [review]
Part u: Remove unused HWND user data functions;
Attachment #801453 - Flags: review?(ehsan)
(Assignee)

Comment 23

6 years ago
Created attachment 801454 [details] [diff] [review]
Part v: Remove unused HWND subclassing functions;
Attachment #801454 - Flags: review?(ehsan)
(Assignee)

Comment 24

6 years ago
Created attachment 801455 [details] [diff] [review]
Part w: Remove unused GetLogonSessionOnlyDACL function;
Attachment #801455 - Flags: review?(ehsan)
(Assignee)

Comment 25

6 years ago
Created attachment 801456 [details] [diff] [review]
Part x: Remove unused GetUserSidString function;
Attachment #801456 - Flags: review?(ehsan)
(Assignee)

Comment 26

6 years ago
Created attachment 801457 [details] [diff] [review]
Part y: Remove unused AddAccessToKernelObject function;
Attachment #801457 - Flags: review?(ehsan)
(Assignee)

Comment 27

6 years ago
Created attachment 801458 [details] [diff] [review]
Part z: Remove unused GetServicePackLevel function;
Attachment #801458 - Flags: review?(ehsan)
(Assignee)

Comment 28

6 years ago
Created attachment 801459 [details] [diff] [review]
Part aa: Remove unused GetNonClientMetrics function;
Attachment #801459 - Flags: review?(ehsan)
(Assignee)

Comment 29

6 years ago
Created attachment 801460 [details] [diff] [review]
Part ab: Remove unused WriteInto function;
Attachment #801460 - Flags: review?(ehsan)
(Assignee)

Comment 30

6 years ago
Feel free to review anything here too.
Flags: needinfo?(bent.mozilla)
IMO these don't need to be reviewed. rs=me for removing anything in ipc/chromium that we don't need (the only two requirements are that it builds and passes tests)!
Flags: needinfo?(bent.mozilla)

Updated

6 years ago
Attachment #801432 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801433 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801434 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801435 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801436 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801437 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801439 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801440 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801441 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801442 - Flags: review?(ehsan) → review+

Comment 32

6 years ago
(In reply to ben turner [:bent] (needinfo? encouraged) from comment #31)
> IMO these don't need to be reviewed. rs=me for removing anything in
> ipc/chromium that we don't need (the only two requirements are that it
> builds and passes tests)!

What Ben said in the future!

Updated

6 years ago
Attachment #801443 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801444 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801445 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801446 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801447 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801448 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801449 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801451 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801452 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801453 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801454 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801455 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801456 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801450 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801457 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801458 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801459 - Flags: review?(ehsan) → review+

Updated

6 years ago
Attachment #801460 - Flags: review?(ehsan) → review+
(Assignee)

Comment 33

6 years ago
https://hg.mozilla.org/mozilla-central/rev/e59f853e6c26
https://hg.mozilla.org/mozilla-central/rev/3d5ec64ea71d
https://hg.mozilla.org/mozilla-central/rev/e6eadf6177a9
https://hg.mozilla.org/mozilla-central/rev/5316beb6adb0
https://hg.mozilla.org/mozilla-central/rev/a5f01ace41b1
https://hg.mozilla.org/mozilla-central/rev/22000376331f
https://hg.mozilla.org/mozilla-central/rev/22c979082c03
https://hg.mozilla.org/mozilla-central/rev/02d635ad7b7c
https://hg.mozilla.org/mozilla-central/rev/2e9624b9aec1
https://hg.mozilla.org/mozilla-central/rev/c00ba1829ba4
https://hg.mozilla.org/mozilla-central/rev/734c93da9910
https://hg.mozilla.org/mozilla-central/rev/d5040d300dba
https://hg.mozilla.org/mozilla-central/rev/af2f22246cd7
https://hg.mozilla.org/mozilla-central/rev/7eaf68ee0c25
https://hg.mozilla.org/mozilla-central/rev/e66af6d88af5
https://hg.mozilla.org/mozilla-central/rev/9d8cdcdc2c0b
https://hg.mozilla.org/mozilla-central/rev/ad53eef2175a
https://hg.mozilla.org/mozilla-central/rev/424b6a293ad6
https://hg.mozilla.org/mozilla-central/rev/1bdcbc9cd60c
https://hg.mozilla.org/mozilla-central/rev/3f44070cab66
https://hg.mozilla.org/mozilla-central/rev/f3fbd500d476
https://hg.mozilla.org/mozilla-central/rev/3c5cf284cbb2
https://hg.mozilla.org/mozilla-central/rev/ad2cf63c716f
https://hg.mozilla.org/mozilla-central/rev/1b5ecb6ba471
https://hg.mozilla.org/mozilla-central/rev/f4f37a20c5e5
https://hg.mozilla.org/mozilla-central/rev/7daf2ec505cd
https://hg.mozilla.org/mozilla-central/rev/6d3ca3b81353
https://hg.mozilla.org/mozilla-central/rev/6c061b718a6d
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.