913953 - Remove more dead Chromium code

Status: RESOLVED FIXED

(Core :: IPC, defect)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

 ipc/chromium/moz.build                              |    1 -
 ipc/chromium/src/base/foundation_utils_mac.h        |   37 ---------
 ipc/chromium/src/base/mac_util.h                    |   24 ------
 ipc/chromium/src/base/mac_util.mm                   |   35 ---------
 ipc/chromium/src/base/process.h                     |   14 ---
 ipc/chromium/src/base/process_posix.cc              |   10 --
 ipc/chromium/src/base/process_util.h                |  110 ----------------------------
 ipc/chromium/src/base/process_util_posix.cc         |  155 ---------------------------------------
 ipc/chromium/src/base/process_util_win.cc           |  308 -------------------------------------------------------------------------------
 ipc/chromium/src/base/process_win.cc                |   63 ----------------
 ipc/chromium/src/base/string_escape.cc              |   98 -------------------------
 ipc/chromium/src/base/string_escape.h               |   35 ---------
 ipc/chromium/src/base/string_util.h                 |   31 -------
 ipc/chromium/src/base/sys_string_conversions.h      |   38 ---------
 ipc/chromium/src/base/sys_string_conversions_mac.mm |   52 -------------
 ipc/chromium/src/base/win_util.cc                   |  346 -----------------------------------------------------------------------------------------
 ipc/chromium/src/base/win_util.h                    |   71 ------------------
 ipc/chromium/src/chrome/common/child_process_info.h |    1 -
 18 files changed, 0 insertions(+), 1429 deletions(-)

https://tbpl.mozilla.org/?tree=Try&rev=9b46a16ece55

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: Remove unused JavascriptDoubleQuote functions;

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Remove unused override app bundle code;

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part c: Remove unused FSRef code;

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part d: Remove unused conversion code to CFStringRef and NSString;

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part e: Remove unused conversion code from CFStringRef and NSString;

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part f: Remove unused process cleanup code;

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part g: Remove unused GetProcessCount function;

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part h: Remove unused WaitForExitCode and GetAppOutput functions;

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part i: Remove unused ReduceWorkingSet and UnReduceWorkingSet functions;

Comment 11

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part j: Remove unused GetWorkingSetKBytes function;

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part k: Remove unused GetCommittedKBytes function;

Comment 13

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part l: Remove unused FreeMBytes struct;

Comment 14

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part m: Remove unused GetPrivateBytes function;

Comment 15

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part n: Remove unused GetWorkingSetSize function;

Comment 16

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part o: Remove unused GetPeakPagefileUsage function;

Comment 17

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part p: Remove unused GetPagefileUsage function;

Comment 18

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part q: Remove unused MatchPattern function;

Comment 19

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part r: Remove unused GetClassName function;

Comment 20

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part s: Remove unused UserAccountControlIsEnabled function;

Comment 21

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part t: Remove unused HWND creation/destruction functions;

Comment 22

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part u: Remove unused HWND user data functions;

Comment 23

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part v: Remove unused HWND subclassing functions;

Comment 24

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part w: Remove unused GetLogonSessionOnlyDACL function;

Comment 25

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part x: Remove unused GetUserSidString function;

Comment 26

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part y: Remove unused AddAccessToKernelObject function;

Comment 27

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part z: Remove unused GetServicePackLevel function;

Comment 28

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part aa: Remove unused GetNonClientMetrics function;

Comment 29

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part ab: Remove unused WriteInto function;

Comment 30

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Feel free to review anything here too.

Comment 31

[Ben Turner (not reading bugmail, use the needinfo flag!)]

IMO these don't need to be reviewed. rs=me for removing anything in ipc/chromium that we don't need (the only two requirements are that it builds and passes tests)!

Comment 32

[(no longer active)]

(In reply to ben turner [:bent] (needinfo? encouraged) from comment #31)
> IMO these don't need to be reviewed. rs=me for removing anything in
> ipc/chromium that we don't need (the only two requirements are that it
> builds and passes tests)!

What Ben said in the future!

Comment 33

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/e59f853e6c26
https://hg.mozilla.org/mozilla-central/rev/3d5ec64ea71d
https://hg.mozilla.org/mozilla-central/rev/e6eadf6177a9
https://hg.mozilla.org/mozilla-central/rev/5316beb6adb0
https://hg.mozilla.org/mozilla-central/rev/a5f01ace41b1
https://hg.mozilla.org/mozilla-central/rev/22000376331f
https://hg.mozilla.org/mozilla-central/rev/22c979082c03
https://hg.mozilla.org/mozilla-central/rev/02d635ad7b7c
https://hg.mozilla.org/mozilla-central/rev/2e9624b9aec1
https://hg.mozilla.org/mozilla-central/rev/c00ba1829ba4
https://hg.mozilla.org/mozilla-central/rev/734c93da9910
https://hg.mozilla.org/mozilla-central/rev/d5040d300dba
https://hg.mozilla.org/mozilla-central/rev/af2f22246cd7
https://hg.mozilla.org/mozilla-central/rev/7eaf68ee0c25
https://hg.mozilla.org/mozilla-central/rev/e66af6d88af5
https://hg.mozilla.org/mozilla-central/rev/9d8cdcdc2c0b
https://hg.mozilla.org/mozilla-central/rev/ad53eef2175a
https://hg.mozilla.org/mozilla-central/rev/424b6a293ad6
https://hg.mozilla.org/mozilla-central/rev/1bdcbc9cd60c
https://hg.mozilla.org/mozilla-central/rev/3f44070cab66
https://hg.mozilla.org/mozilla-central/rev/f3fbd500d476
https://hg.mozilla.org/mozilla-central/rev/3c5cf284cbb2
https://hg.mozilla.org/mozilla-central/rev/ad2cf63c716f
https://hg.mozilla.org/mozilla-central/rev/1b5ecb6ba471
https://hg.mozilla.org/mozilla-central/rev/f4f37a20c5e5
https://hg.mozilla.org/mozilla-central/rev/7daf2ec505cd
https://hg.mozilla.org/mozilla-central/rev/6d3ca3b81353
https://hg.mozilla.org/mozilla-central/rev/6c061b718a6d