914079 - The whole pseudo elements bar should be clickable

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Anthony Ricaud (:rik)]

Right now, only the arrow is clickable and that's a small target.

Comment 1

[Patrick Brosset <:pbro>]

For info, I'm working on bug 913014 which aims at doing the same for the computed styles view.
Also, bug 855523 should land shortly, and this one aims at doing the same too for the markup view.
So it makes sense, for consistency reasons, whenever we have a horizontal container with an expand/collapse twisty, that the whole container also serves as an expand/collapse element.
Having said this, both the markup and computed views are going to have it on dblclick, not click. Only the twisty is single clickable.

Comment 2

[Patrick Brosset <:pbro>]

Attachment: 914079-dblclick-pseudo.patch

This patch allows users to dblclick on the pseudo element header itself.
The twisty remains clickable as before.

This patch also contains an attempt for a mochitest browser test that I haven't been able to finalize.
It's basically using the `EventUtils.sendMouseEvent({type:"dblclick"}...)` API which doesn't seem to work at all for me.

Any help about why that might be would be great!

Comment 3

[Patrick Brosset <:pbro>]

Attachment: 914079-dblclick-pseudo.patch

Uploading a new version of the same patch after having finally found a way to simulate double click events.

Comment 4

[Patrick Brosset <:pbro>]

Thank you Mike for the review!

Comment 5

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/2a0b716e7be4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2a0b716e7be4