914115 - [e.me][feature] Homescreen will expose an API to rename icons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Cristian Rodriguez (:crdlc)]

Collections can be renamed so we need to support it in homescreen part

Comment 1

[Cristian Rodriguez (:crdlc)]

The first version could be something like this

https://github.com/crdlc/gaia/commit/ee9537eb30cb56a81b554e050760ba5053b16428#L1L121

Comment 2

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 3

[Ran Ben Aharon [:ranbena] EverythingMe]

Evyatar, notice the API suggested expects Collection origin as an identifier.
Do we hold this parameter for Collections?

Comment 4

[Evyatar 'Tron' Amitay (everything.me)]

I'm pretty sure we save this in our index, our ID should be the origin URL.
Amir can give a definitive answer.

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

It seems we generate an id instead.

Comment 6

[Cristian Rodriguez (:crdlc)]

I am sure because it is working fine

https://github.com/mozilla-b2g/gaia/pull/12442/files#L1R180

Comment 7

[Amir Nissim (:amirn)]

There are two cases:

1. "pre-cooked" collections have an id created by homescreen (which is the origin, if I'm not mistaken)
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/js/Core.js#L113

2. any collection later created by the user has a generated id
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/modules/Collection/Collection.js#L389

Comment 8

[Cristian Rodriguez (:crdlc)]

(In reply to Amir Nissim (Everything.me) from comment #7)
> There are two cases:
> 
> 1. "pre-cooked" collections have an id created by homescreen (which is the
> origin, if I'm not mistaken)
> https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.
> me/js/Core.js#L113
> 

Right

> 2. any collection later created by the user has a generated id
> https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.
> me/modules/Collection/Collection.js#L389

In this case when you create a collection you can pass the id as bookmarkURL as well in the descriptor

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/js/etmmanager.js#L14

Comment 9

[Amir Nissim (:amirn)]

the 'id' is used to create a new gridItem with identical origin and id
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/modules/Collection/Collection.js#L459-L460

the originURL is then passed as the bookmarkURL
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/js/etmmanager.js#L17

and finally saved as origin
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/grid_components.js#L29-L30

this is all very confusing.. we have started talking about using a single unique 'id' field to reference grid items. maybe it's time..

Comment 10

[Amir Nissim (:amirn)]

but, yes, as Cristian said, it will work.

Comment 11

[Cristian Rodriguez (:crdlc)]

you can fill a bug for that although not for v1.2

Comment 12

[Evyatar 'Tron' Amitay (everything.me)]

Cristian, I'm checking the patch - it seems like if I call setIconName on a collection, and then getIconName (after a few seconds) I still get the old name. Also after re-building the homescreen the name reverts to the old one.

Comment 13

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/pull/12442/files#L0R229

Are you retrieving here the icon? Is the name changed on the grid?

Comment 14

[Evyatar 'Tron' Amitay (everything.me)]

1. call setIconName
2. The name changes on the grid
3. call getIconName
4. I get the OLD name

1. call setIconName
2. The name changes on the grid
3. Build the homescreen app again
4. The name is now the OLD one

Comment 15

[Cristian Rodriguez (:crdlc)]

Please take a look to this code https://github.com/mozilla-b2g/gaia/pull/12442/files#L3R456 because I cannot test it on my device and you are working on rename collections bug

Comment 16

[Evyatar 'Tron' Amitay (everything.me)]

Comment on attachment 809884 [details]
Patch v1

Tested, and the issue I had came from OUR code, not this PR. So this is working and can be landed.

Comment 17

[Cristian Rodriguez (:crdlc)]

ok thanks, waiting for Travis

Comment 18

[Evyatar 'Tron' Amitay (everything.me)]

All is well from Travis!

Comment 19

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/0cca9d9d7d29fba461166e49e5869f90e9141132