Closed Bug 914272 Opened 10 years ago Closed 10 years ago

move IS_COMPONENT to mozbuild

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: joey, Assigned: Cykesiopka)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

bug914272_v1.patch
13.77 KB, patch
joey
: review+
Details | Diff | Splinter Review 
passthrough variable already added, Makefile.in still needs to be converted.

% find . -name 'Makefile.in' | xargs grep IS_COMPONENT
./js/xpconnect/tests/components/js/Makefile.in:IS_COMPONENT = 1
./js/xpconnect/tests/components/native/Makefile.in:IS_COMPONENT = 1
./extensions/gnomevfs/Makefile.in:IS_COMPONENT	= 1
./extensions/widgetutils/src/Makefile.in:IS_COMPONENT = 1
./xpcom/sample/Makefile.in:# IS_COMPONENT indicates that this makefile builds a component shared library.
./xpcom/sample/Makefile.in:IS_COMPONENT	= 1
./xpcom/tests/component_no_aslr/Makefile.in:IS_COMPONENT	= 1
./xpcom/tests/component/Makefile.in:IS_COMPONENT	= 1
./xpcom/tests/bug656331_component/Makefile.in:IS_COMPONENT	= 1
./xulrunner/examples/simple/components/src/Makefile.in:IS_COMPONENT	= 1
./toolkit/system/dbus/Makefile.in:IS_COMPONENT = 1
./toolkit/system/gnome/Makefile.in:IS_COMPONENT	= 1
./rdf/tests/dsds/Makefile.in:IS_COMPONENT	= 1
./browser/components/build/Makefile.in:IS_COMPONENT = 1
Blocks: nomakefiles
Something like this...?
Attachment #804993 - Flags: review?(joey)
Comment on attachment 804993 [details] [diff] [review]
bug914272_v1.patch

Review of attachment 804993 [details] [diff] [review]:
-----------------------------------------------------------------

Transfer of boolean assignments looks good.
Attachment #804993 - Flags: review?(joey) → review+
Thanks for the review!
Assignee: nobody → cykesiopka.bmo
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f7276b599536
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.