Closed Bug 914274 Opened 6 years ago Closed 6 years ago

Remove MODULE_NAME

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: joey, Assigned: glandium)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(4 files)

% find . -name "Makefile.in" | xargs grep 'MODULE_NAME'
./js/xpconnect/tests/components/js/Makefile.in:MODULE_NAME = xpconnect_test
./js/xpconnect/tests/components/native/Makefile.in:MODULE_NAME = xpconnect_test
./xpcom/sample/Makefile.in:# If this is Makefile builds a component, MODULE_NAME must match the module
./xpcom/sample/Makefile.in:MODULE_NAME	= nsSampleModule
./media/omx-plugin/gb235/Makefile.in:MODULE_NAME = omxplugingb235
./media/omx-plugin/froyo/Makefile.in:MODULE_NAME = omxpluginfroyo
./media/omx-plugin/lib/gb235/libstagefright/Makefile.in:MODULE_NAME = libandroidstagefrightgb234
./media/omx-plugin/lib/froyo/libstagefright/Makefile.in:MODULE_NAME = libandroidstagefrightfroyo
./media/omx-plugin/lib/ics/libutils/Makefile.in:MODULE_NAME = libandroidutils
./media/omx-plugin/lib/ics/libstagefright/Makefile.in:MODULE_NAME = libandroidstagefright
./media/omx-plugin/lib/gb/libutils/Makefile.in:MODULE_NAME = libandroidutilsgb
./media/omx-plugin/lib/gb/libstagefright_color_conversion/Makefile.in:MODULE_NAME = libstagefright_color_conversion
./media/omx-plugin/lib/gb/libstagefright/Makefile.in:MODULE_NAME = libandroidstagefrightgb
./media/omx-plugin/lib/hc/libstagefright/Makefile.in:MODULE_NAME = libandroidstagefrighthc
./media/omx-plugin/gb/Makefile.in:MODULE_NAME = omxplugingb
./media/omx-plugin/hc/Makefile.in:MODULE_NAME = omxpluginhc
./media/omx-plugin/Makefile.in:MODULE_NAME = omxplugin
./dom/plugins/test/testplugin/secondplugin/Makefile.in:MODULE_NAME  = SecondTestPlugin
./dom/plugins/test/testplugin/Makefile.in:MODULE_NAME  = TestPlugin
./browser/components/build/Makefile.in:MODULE_NAME = nsBrowserCompsModule
Assignee: nobody → Ms2ger
Attached patch Part a: supportSplinter Review
Attachment #816018 - Flags: review?(mshal)
Attached patch Part b: moveSplinter Review
Attachment #816019 - Flags: review?(mshal)
Attached patch Part c: disallowSplinter Review
Attachment #816020 - Flags: review?(mshal)
Per IRC chat - does MODULE_NAME still even do anything? The only references I see are in config/rules.mk and config/config.mk. In both cases it just prints an error message if MODULE_NAME isn't set in certain conditions, but it doesn't appear to actually do anything with the value.
Comment on attachment 816018 [details] [diff] [review]
Part a: support

r-'ing these since we should just remove MODULE_NAME rather than port it to moz.build.
Attachment #816018 - Flags: review?(mshal) → review-
Attachment #816019 - Flags: review?(mshal) → review-
Attachment #816020 - Flags: review?(mshal) → review-
Summary: move MODULE_NAME to mozbuild → Remove MODULE_NAME
Interesting fact, since the removal of MODULE_NAME for static components, there are exactly only two places where the value of MODULE_NAME is what it was supposed to be (and one of those is xpcom/sample). None of the other places where MODULE_NAME has a value corresponds to a NSMODULE definition (which is what MODULE_NAME was supposed to reflect)
Attachment #8334371 - Flags: review?(mshal)
Assignee: Ms2ger → mh+mozilla
Status: NEW → ASSIGNED
Attachment #8334371 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/49d39e1c4a5d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.