If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove MODULE_NAME

RESOLVED FIXED in mozilla28

Status

()

Core
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: joey, Assigned: glandium)

Tracking

(Blocks: 1 bug)

unspecified
mozilla28
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(4 attachments)

(Reporter)

Description

4 years ago
% find . -name "Makefile.in" | xargs grep 'MODULE_NAME'
./js/xpconnect/tests/components/js/Makefile.in:MODULE_NAME = xpconnect_test
./js/xpconnect/tests/components/native/Makefile.in:MODULE_NAME = xpconnect_test
./xpcom/sample/Makefile.in:# If this is Makefile builds a component, MODULE_NAME must match the module
./xpcom/sample/Makefile.in:MODULE_NAME	= nsSampleModule
./media/omx-plugin/gb235/Makefile.in:MODULE_NAME = omxplugingb235
./media/omx-plugin/froyo/Makefile.in:MODULE_NAME = omxpluginfroyo
./media/omx-plugin/lib/gb235/libstagefright/Makefile.in:MODULE_NAME = libandroidstagefrightgb234
./media/omx-plugin/lib/froyo/libstagefright/Makefile.in:MODULE_NAME = libandroidstagefrightfroyo
./media/omx-plugin/lib/ics/libutils/Makefile.in:MODULE_NAME = libandroidutils
./media/omx-plugin/lib/ics/libstagefright/Makefile.in:MODULE_NAME = libandroidstagefright
./media/omx-plugin/lib/gb/libutils/Makefile.in:MODULE_NAME = libandroidutilsgb
./media/omx-plugin/lib/gb/libstagefright_color_conversion/Makefile.in:MODULE_NAME = libstagefright_color_conversion
./media/omx-plugin/lib/gb/libstagefright/Makefile.in:MODULE_NAME = libandroidstagefrightgb
./media/omx-plugin/lib/hc/libstagefright/Makefile.in:MODULE_NAME = libandroidstagefrighthc
./media/omx-plugin/gb/Makefile.in:MODULE_NAME = omxplugingb
./media/omx-plugin/hc/Makefile.in:MODULE_NAME = omxpluginhc
./media/omx-plugin/Makefile.in:MODULE_NAME = omxplugin
./dom/plugins/test/testplugin/secondplugin/Makefile.in:MODULE_NAME  = SecondTestPlugin
./dom/plugins/test/testplugin/Makefile.in:MODULE_NAME  = TestPlugin
./browser/components/build/Makefile.in:MODULE_NAME = nsBrowserCompsModule

Updated

4 years ago
Assignee: nobody → Ms2ger

Updated

4 years ago
Blocks: 847009
Created attachment 816018 [details] [diff] [review]
Part a: support
Attachment #816018 - Flags: review?(mshal)
Created attachment 816019 [details] [diff] [review]
Part b: move
Attachment #816019 - Flags: review?(mshal)
Created attachment 816020 [details] [diff] [review]
Part c: disallow
Attachment #816020 - Flags: review?(mshal)
Per IRC chat - does MODULE_NAME still even do anything? The only references I see are in config/rules.mk and config/config.mk. In both cases it just prints an error message if MODULE_NAME isn't set in certain conditions, but it doesn't appear to actually do anything with the value.
Comment on attachment 816018 [details] [diff] [review]
Part a: support

r-'ing these since we should just remove MODULE_NAME rather than port it to moz.build.
Attachment #816018 - Flags: review?(mshal) → review-

Updated

4 years ago
Attachment #816019 - Flags: review?(mshal) → review-

Updated

4 years ago
Attachment #816020 - Flags: review?(mshal) → review-
(Assignee)

Updated

4 years ago
Summary: move MODULE_NAME to mozbuild → Remove MODULE_NAME
(Assignee)

Comment 6

4 years ago
Created attachment 8334371 [details] [diff] [review]
Remove MODULE_NAME

Interesting fact, since the removal of MODULE_NAME for static components, there are exactly only two places where the value of MODULE_NAME is what it was supposed to be (and one of those is xpcom/sample). None of the other places where MODULE_NAME has a value corresponds to a NSMODULE definition (which is what MODULE_NAME was supposed to reflect)
Attachment #8334371 - Flags: review?(mshal)
(Assignee)

Updated

4 years ago
Assignee: Ms2ger → mh+mozilla
Status: NEW → ASSIGNED

Updated

4 years ago
Attachment #8334371 - Flags: review?(mshal) → review+
(Assignee)

Comment 7

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/49d39e1c4a5d
https://hg.mozilla.org/mozilla-central/rev/49d39e1c4a5d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

4 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.