91432 - Mozilla used to freeze on .CFM imagemap link

Status: NEW

(Core :: Layout, defect, P4)

Description

[Brett Gneiting]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.2+)
Gecko/20010714
BuildID:    20010714

On Wacom.com's Index page when you click on the Purple/North America section of
the imagemap Mozilla will immediately freeze. I assume this has something to do
with the fact that the link is a .cfm page since the other parts that do not
link to .cfm pages don't freeze Mozilla.

Reproducible: Always
Steps to Reproduce:
1.Goto http://www.wacom.com
2.Click on Purple/North America area of the imagemap
3.

Actual Results:  Mozilla immediately froze

Expected Results:  Should goto the Wacom America page

Only parts of the North America landmass are clickable, while the whole area
should be/works in IE.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Weird.  This works fine in a debug build but it's broken in an optimized build.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We spend a few seconds at a time in a for loop in "INNER LOOP", but then every 
few seconds go out to "OUTER LOOP".

GDI32! 77f67cc6()          <=== INNER LOOP
GKGFXWIN! 0222503d()
GKLAYOUT! 024ff86e()
GKLAYOUT! 02500ebc()
GKLAYOUT! 024e8104()
GKLAYOUT! 024de878()
GKLAYOUT! 024fd083()
GKLAYOUT! 024fcefa()
GKLAYOUT! 024de878()
GKLAYOUT! 024de787()
GKLAYOUT! 025444b4()
GKLAYOUT! 02542398()
GKLAYOUT! 025411d4()
GKLAYOUT! 0253d812()
GKLAYOUT! 0253d734()
GKLAYOUT! 024de878()
GKLAYOUT! 024de787()
GKLAYOUT! 025382be()
GKLAYOUT! 024de878()
GKLAYOUT! 025335ea()
GKLAYOUT! 024de878()
GKLAYOUT! 024fd083()
GKLAYOUT! 024fcefa()
GKLAYOUT! 024de878()
GKLAYOUT! 024fd083()
GKLAYOUT! 024fcefa()
GKLAYOUT! 024de878()
GKLAYOUT! 024de787()
GKLAYOUT! 024e4e0d()
GKLAYOUT! 024b310e()
GKLAYOUT! 024da22d()     <==== "OUTER LOOP"
GKVIEW! 0261150d()
GKVIEW! 0261979f()
GKVIEW! 02618f21()
GKVIEW! 026184b5()
GKVIEW! 0261a7a0()
GKVIEW! 026124cf()
GKWIDGET! 018e8975()
GKWIDGET! 018e8a0f()
GKWIDGET! 018ecfc2()
GKWIDGET! 018eb696()
GKWIDGET! 018e905e()
USER32! 77e13eb0()
USER32! 77e1591b()
USER32! 77e1595d()
NTDLL! 77f9fb83()
GKVIEW! 0261a002()
GKVIEW! 0261a509()
GKLAYOUT! 025014ce()
GKLAYOUT! 0250137e()
GKLAYOUT! 025010d1()
GKCONTENT! 02165d5e()
GKCONTENT! 020509e5()
GKCONTENT! 02072dab()
GKCONTENT! 0218f195()
GKCONTENT! 0215d79d()
GKCONTENT! 0215c24c()
GKCONTENT! 0207329e()
GKCONTENT! 0218f195()
GKLAYOUT! 024da9b5()
GKLAYOUT! 024da7e7()
GKVIEW! 0261173f()
GKVIEW! 026116cf()
GKVIEW! 026116cf()
GKVIEW! 0261ad09()
GKVIEW! 026124cf()
GKWIDGET! 018e8975()
GKWIDGET! 018e89e2()
GKWIDGET! 018ed3ec()
GKWIDGET! 018eda80()
GKWIDGET! 018ebbf9()
GKWIDGET! 018e905e()
USER32! 77e13eb0()
USER32! 77e1401a()
USER32! 77e192da()
APPSHELL! 0144ad2c()
MOZILLA! 00401ceb()
MOZILLA! 00401358()
MOZILLA! 00404fe4()
MOZILLA! 0040a25c()
KERNEL32! 77e87903()

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: somewhat simplified testcase

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Both problems (the hang and not having the whole area work) seem related to 
having a newline within the COORDS attribute.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: simple testcase

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Maybe this is because lo_parse_coord_list was copied from code where 
XP_IS_SPACE is defined in the old mozilla/include rather than the different 
definition in nsTextFragment.h.  But why the hang?

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch to fix parsing problem

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I still don't understand why the crash was happening (it's hard for me to tell 
*where* it was crashing since it was optimized-only).  But I have a little more 
cleanup of this parsing function, at least...

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: more cleanup of parsing function

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

taking

Comment 11

[Chris Waterson]

r/sr=waterson

Comment 12

[jag (Peter Annema)]

Nice, making sure that if it's a tab, it's whitespace! (You know, just in case
the compiler missed it the first time) ;-)

``While you're there ...'' fix the whitespace around the && and || in the lines
you touch.

Comment 13

[jag (Peter Annema)]

But r=jag anyway ;-)

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

OK, checked in (2001-07-24 22:14 PDT).  I still should try to figure out why it
was crashing in the first place when the coordinates were parsed incorrectly.

Comment 15

[Heikki Toivonen (remove -bugzilla when emailing directly)]

SPAM. HTML Element component deprecated, changing component to Layout. See bug
88132 for details.