914324 - "JavaScript strict warning: chrome://browser/content/browser.js, line 5886: assignment to undeclared variable SocialStatus" warning in debug build startup output

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Noticed this in some Jetpack test logs recently. Figured it was worth filing.

https://tbpl.mozilla.org/php/getParsedLog.php?id=27572876&tree=Mozilla-Inbound

JavaScript strict warning: chrome://browser/content/browser.js, line 5886: assignment to undeclared variable SocialStatus

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix: add "let" to declare the variable

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #0)
> Noticed this in some Jetpack test logs recently. Figured it was worth filing.

I think we hit this in all debug builds. I see it in my startup-spew of my local debug build -- it's the ~10th line of output on my system (intermixed with some "++DOMWINDOW" lines).

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 801756 [details] [diff] [review]
fix: add "let" to declare the variable


:(

Hi Daniel,
Add SocialStatus to the let list at the top of browser-social.js (it needs to be global due to the button oncommand).  r=me with that.
Shane

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: updated fix w/ review comment addressed

Gotcha. Thanks for the r+!  inbound is currently closed, so I'm posting the updated patch as checkin-needed.

Comment 6

[Daniel Holbert [:dholbert]]

Inbound's open again, so I landed:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/a9ccc26e524b

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/a9ccc26e524b