Differential Testing: Different output message involving eval

RESOLVED FIXED in mozilla26

Status

()

--
major
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gkw, Assigned: jandem)

Tracking

(Blocks: 2 bugs, {testcase})

Trunk
mozilla26
x86
Mac OS X
testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
function f() {
    [eval("this()")]
}
for (a in [0, 0, 0]) {
    try {
        f()
    } catch (e) {
        print(e)
    }
}

prints an additional TypeError in js debug shell on m-c changeset 3697f962bb7b with --ion-eager:

TypeError: undefined is not a function

which does not show without --ion-eager.

My configure flags are:

LD=ld CROSS_COMPILE=1 CXX="clang++ -Qunused-arguments -arch i386" RANLIB=ranlib CC="clang -Qunused-arguments -arch i386" AS=$CC AR=ar STRIP="strip -x -S" HOST_CC="clang -Qunused-arguments" HOST_CXX="clang++ -Qunused-arguments" sh ./configure --target=i386-apple-darwin9.2.0 --enable-macos-target=10.5 --enable-optimize --enable-debug --enable-profiling --enable-gczeal --enable-debug-symbols --enable-methodjit --enable-type-inference --disable-tests --enable-more-deterministic --with-ccache --enable-threadsafe <other NSPR options>
Flags: needinfo?(jdemooij)
(Assignee)

Comment 1

5 years ago
Created attachment 802202 [details] [diff] [review]
Patch

BC was not wrapping |this| in eval/global scripts.
Assignee: general → jdemooij
Status: NEW → ASSIGNED
Attachment #802202 - Flags: review?(kvijayan)
Flags: needinfo?(jdemooij)

Updated

5 years ago
Attachment #802202 - Flags: review?(kvijayan) → review+
https://hg.mozilla.org/mozilla-central/rev/aca02ab3f2d3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
(Reporter)

Updated

5 years ago
Depends on: 916039
(Reporter)

Updated

5 years ago
Depends on: 922118
(Assignee)

Updated

5 years ago
No longer depends on: 922118
You need to log in before you can comment on or make changes to this bug.