914341 - Differential Testing: Different output message involving eval

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

function f() {
    [eval("this()")]
}
for (a in [0, 0, 0]) {
    try {
        f()
    } catch (e) {
        print(e)
    }
}

prints an additional TypeError in js debug shell on m-c changeset 3697f962bb7b with --ion-eager:

TypeError: undefined is not a function

which does not show without --ion-eager.

My configure flags are:

LD=ld CROSS_COMPILE=1 CXX="clang++ -Qunused-arguments -arch i386" RANLIB=ranlib CC="clang -Qunused-arguments -arch i386" AS=$CC AR=ar STRIP="strip -x -S" HOST_CC="clang -Qunused-arguments" HOST_CXX="clang++ -Qunused-arguments" sh ./configure --target=i386-apple-darwin9.2.0 --enable-macos-target=10.5 --enable-optimize --enable-debug --enable-profiling --enable-gczeal --enable-debug-symbols --enable-methodjit --enable-type-inference --disable-tests --enable-more-deterministic --with-ccache --enable-threadsafe <other NSPR options>

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Patch

BC was not wrapping |this| in eval/global scripts.

Comment 2

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aca02ab3f2d3

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aca02ab3f2d3