914609 - Inconsistent references to plugin placeholder elements

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[[e-mail]]

Now that bug 910899 added anonids to the plugin placeholder elements that need it, the front-end code should switch to use it consistently.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 802283 [details] [diff] [review]
Proposed patch

Review of attachment 802283 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-plugins.js
@@ +886,5 @@
>      //
>  
>      // Force a layout flush so the binding is attached.
>      plugin.clientTop;
>      let doc = plugin.ownerDocument;

Can you move the declaration of doc to be closer to its first reference?

Comment 3

[[e-mail]]

Comment on attachment 802283 [details] [diff] [review]
Proposed patch

>     // Force a layout flush so the binding is attached.
>     plugin.clientTop;
>     let doc = plugin.ownerDocument;
>-    let overlay = doc.getAnonymousElementByAttribute(plugin, "class", "mainBox");
>-    let statusDiv = doc.getAnonymousElementByAttribute(plugin, "class", "submitStatus");
>+    let overlay = this.getPluginUI(plugin, "main");
>+    let statusDiv = this.getPluginUI(plugin, "submitStatus");
> #ifdef MOZ_CRASHREPORTER
There are further references after the #ifdef block too, but the the next reference of doc is inside the #ifdef block, so the best I can do is to move it down after the two changed lines.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Yeah that sounds good.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aa3655d26fce