910899 - Inconsistent references to plugin placeholder elements

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[[e-mail]]

Some of the plugin placeholder elements are accessed by class name and some by anonid. We should be consistent and access everything by anonid. This bug is to cover the first step of adding anonid to the elements that need it but don't yet have it. Then each application can switch their front-end code from class name to anonid.

Comment 1

[[e-mail]]

Attachment: Proposed patch

I guess the other alternative would be to switch everyone over to using the existing class names and remove all of the anonids. We even have the helper function getPluginUI for this, although we don't use it everywhere for some reason.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Can you update the references to the class names to point to the new anonid's?

Comment 3

[[e-mail]]

(In reply to Jared Wein from comment #2)
> Can you update the references to the class names to point to the new
> anonid's?

I wanted to do that in followup bugs (one for each application).

Comment 4

[[e-mail]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/365e150efda0

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/7509132548d9 for various plugin-related failures.

Comment 6

[[e-mail]]

Pushed with typo fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af2e93b2f712

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/af2e93b2f712

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Neil's followup, http://hg.mozilla.org/integration/mozilla-inbound/rev/ebebb890be3b

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/ebebb890be3b