914624 - Reader Mode toolbar is not displayed in landscape

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Reader View, defect, P5)

Description

[Ioana Chiorean]

Device: Acer Iconia A500 
OS: Android 3.2.1
Fennec 24 Beta 10 build 1

Steps to Reproduce:

1. Go to nytimes.com and open an article
2. Tap reader mode icon 
3. Dismiss the toolbar
4. Being in landscape Tap the article so the toolbar appears
5. Switch to portrait 

Actual Results:  
- the toolbar is not displayed in landscape after first dismiss

Expected Results:  
- the toolbar should be displayed after a tap on the page

Note: 
- This is not reproducible on other devices (nor tablets, nor phones.)
- This is intermittently reproducible on Nightly and Aurora too

Comment 1

[Catalin Suciu [:csuciu]]

I can reproduce this issue on Asus Transformer (Android 4.0.3) when viewing nytimes.com, bbc.com, huffingtonpost.com articles in reader mode

Comment 2

[Ioana Chiorean]

Last good build: 2013-06-03
First bad build: 2013-06-04

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=198e38876f7e&tochange=7e3a4ebcf067

I suspect one the following cause it:	
Lucas Rocha — Bug 877735 - Slide menu icon with other buttons in toolbar animation (r=mfinkle)
Lucas Rocha — Bug 877140 - Fade in toolbar buttons while hiding tabs tray (r=mfinkle)
Lucas Rocha — Bug 877140 - Add duration getter to PropertyAnimator (r=mfinkle)

If you disagree I will continue with an inbound regression.

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to Ioana Chiorean from comment #2)
> Last good build: 2013-06-03
> First bad build: 2013-06-04
> 
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=198e38876f7e&tochange=7e3a4ebcf067
> 
> I suspect one the following cause it:	
> Lucas Rocha — Bug 877735 - Slide menu icon with other buttons in toolbar
> animation (r=mfinkle)
> Lucas Rocha — Bug 877140 - Fade in toolbar buttons while hiding tabs tray
> (r=mfinkle)
> Lucas Rocha — Bug 877140 - Add duration getter to PropertyAnimator
> (r=mfinkle)
> 
> If you disagree I will continue with an inbound regression.

These are all unrelated to reader mode. The reader mode UI is implemented in HTML. My first guess is that this is related to some change in our graphics code i.e. the way we handle fixed position elements in the page.

Comment 4

[Aaron Train [:aaronmt]]

Is this still an issue?

Comment 5

[Mark Capella [:capella]]

Attachment: readerMode_Landscape_N7.png

Maybe related / maybe new issue (?)

In nightly, the banner appearance in readerMode landscape on my tablet (N7) has it's icons all smooshed to the right (see attachment)

Comment 6

[Mark Capella [:capella]]

(Apologies if that's the design)

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

filter on [mass-p5]