914635 - "Search Unavailable" is displayed when search results are sorted by Name

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Search, defect)

Description

[Iulian Timis]

Steps to reproduce:
1. Load AMO-dev homepage https://addons-dev.allizom.org/en-US/firefox/
2. Perform a blank search.
3. Click on Sort by: Name.

Expected results:
The search results are sorted by Name.

Actual results:
User is redirected to an error page "Search Unavailable"

Notes/Issues:
Verified on FF23 (Win 7). Issue is also reproducing in production.
Screencast for this issue http://screencast.com/t/7mLgCnRs

Comment 1

[Rob Hudson [:robhudson]]

I'd imagine this bug has existed for awhile since nothing has really changed on AMO. It seems to happen on any name sort, not just empty ones.

From the logs I see this query:
Sep 10 09:35:18 dev2.addons.phx1.mozilla.com: [][] z.es:ERROR {'filter': {'and': [{'term': {'app': 1}}, {'term': {'is_disabled': False}}, {'in': {'status': (8, 9, 4)}}, {'in': {'platform': (3, 1)}}, {'in': {'type': (1, 2, 3, 4, 5)}}]}, 'fields': ['id'], 'facets': {'platforms': {'terms': {'field': 'platform'}}, 'appversions': {'terms': {'field': 'appversion.1.max'}}, 'categories': {'terms': {'field': 'category', 'size': 200}}, 'tags': {'terms': {'field': 'tag'}}}, 'size': 20, 'sort': ['name_sort']} :/data/addons-dev/www/addons-dev.allizom.org/deploy-zamboni-dev-20130910084817-6c8f94e3fe/zamboni/apps/amo/search.py:267

And this Elasticsearch exception:
Sep 10 09:35:18 dev1.addons.phx1.mozilla.com: [][] z.es:ERROR Elasticsearch error: Failed to execute phase [query], all shards failed; shardFailures {[p3wz-DhNRcmKN0oF4U1z0Q][addons_dev-20130513131826][4]: QueryPhaseExecutionException[[addons_dev-20130513131826][4]: query[ConstantScore(cache(_type:addons))],from[0],size[20],sort[<custom:"name_sort": org.elasticsearch.index.fielddata.fieldcomparator.BytesRefFieldComparatorSource@57eaada6>]: Query Failed [Failed to execute main query]]; nested: NullPointerException; }{[q8uz42I-TWSZ3qqOrxn8ew][addons_dev-20130513131826][0]: RemoteTransportException[[elasticsearch3_addons_phx1][inet[/10.8.83.169:9300]][search/phase/query]]; nested: QueryPhaseExecutionException[[addons_dev-20130513131826][0]: query[ConstantScore(cache(_type:addons))],from[0],size[20],sort[<custom:"name_sort": org.elasticsearch.index.fielddata.fieldcomparator.BytesRefFieldComparatorSource@2a66d465>]: Query Failed [Failed to execute main query]]; nested: NullPointerException; }{[p3wz-DhNRcmKN0oF4U1z0Q][addons_dev-20130513131826][1]: QueryPhaseExecutionException[[addons_dev-20130513131826][1]: query[ConstantScore(cache(_type:addons))],from[0],size[20],sort[<custom:"name_sort": org.elasticsearch.index.fielddata.fieldcomparator.BytesRefFieldComparatorSource@2258428c>]: Query Failed [Failed to execute main query]]; nested: NullPointerException; }{[M6mJtEITSfu16-6TGCJ7LA][addons_dev-20130513131826][2]: RemoteTransportException[[elasticsearch2_addons_phx1][inet[/10.8.83.168:9300]][search/phase/query]]; nested: QueryPhaseExecutionException[[addons_dev-20130513131826][2]: query[ConstantScore(cache(_type:addons))],from[0],size[20],sort[<custom:"name_sort": org.elasticsearch.index.fielddata.fieldcomparator.BytesRefFieldComparatorSource@5befb3>]: Query Failed [Failed to execute main query]]; nested: NullPointerException; }{[q8uz42I-TWSZ3qqOrxn8ew][addons_dev-20130513131826][3]: RemoteTransportException[[elasticsearch3_addons_phx1][inet[/10.8.83.169:9300]][search/phase/query]]; nested: Quer

Comment 2

[Rob Hudson [:robhudson]]

This is a bug in Elasticsearch 0.90.3:
https://github.com/elasticsearch/elasticsearch/issues/3470

We will upgrade to 0.90.5 within the week. First on dev/stage and then on prod.

Comment 3

[Jason Thomas [:jason]]

Dev/stage elasticsearch upgraded to 0.90.5.

Comment 4

[Iulian Timis]

Issue is no longer reproducing.

Comment 5

[Iulian Timis]

Verified as fixed in https://addons-dev.allizom.org/en-US/firefox/search/ on FF24 (Win 7).
Postfix screencast http://screencast.com/t/jsurU5Z4
Closing bug.