Closed Bug 914659 Opened 11 years ago Closed 7 years ago

B2G RIL: Writing marionette test for removing ICC Contact

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(tracking-b2g:backlog)

RESOLVED WONTFIX
tracking-b2g backlog

People

(Reporter: allstars.chh, Unassigned)

References

Details

(Whiteboard: [grooming])

Attachments

(1 file, 2 obsolete files)

Currently in marionette tests for icc contact, we only test reading and adding. We also need to have tests for removing.
Assignee: nobody → gwang
Depends on: 935399
Attachment #828515 - Attachment is obsolete: true
Attachment #828556 - Flags: review?(allstars.chh)
Comment on attachment 828556 [details] [diff] [review] Add remove contact marionette test. Review of attachment 828556 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/icc/tests/marionette/test_icc_contact.js @@ +99,5 @@ > + updateRequest.onsuccess = function onsuccess() { > + if (type === "fdn" && pin2 === undefined) { > + ok(false, "Should not update fdn when pin2 is not provided"); > + runNextTest(); > + } I don't understand what you're tring to do here. @@ +108,5 @@ > + getRequest.onsuccess = function onsuccess() { > + let contacts = getRequest.result; > + > + // There are 4 SIM contacts which are harded in emulator > + is(contacts.length, 4); What's this check for ? @@ +159,5 @@ > + testRemoveContact("fdn"); > +} > + > +function testRemoveFdnContactWithoutPassingPin2() { > + testRemoveContact("fdn", "0000"); WithPassingPin2? what's "0000" here?
Attachment #828556 - Flags: review?(allstars.chh) → review-
(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #4) > Comment on attachment 828556 [details] [diff] [review] > Add remove contact marionette test. > > Review of attachment 828556 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/icc/tests/marionette/test_icc_contact.js > @@ +99,5 @@ > > + updateRequest.onsuccess = function onsuccess() { > > + if (type === "fdn" && pin2 === undefined) { > > + ok(false, "Should not update fdn when pin2 is not provided"); > > + runNextTest(); > > + } > > I don't understand what you're tring to do here. There's no check for: no pin2 but update FDN case. like Bug 935399. So I want to add test for this part. > @@ +108,5 @@ > > + getRequest.onsuccess = function onsuccess() { > > + let contacts = getRequest.result; > > + > > + // There are 4 SIM contacts which are harded in emulator > > + is(contacts.length, 4); > > What's this check for ? In previous test, we add contact id = 5 in both ADN and FDN. So if we remove contactId = 5, there should be only 4 contacts as default. > @@ +159,5 @@ > > + testRemoveContact("fdn"); > > +} > > + > > +function testRemoveFdnContactWithoutPassingPin2() { > > + testRemoveContact("fdn", "0000"); > > WithPassingPin2? > > what's "0000" here? Sorry, the name should be switch between the two functions. Since the code here has some change for multiple ICCs, I made some change and will update patch later.
Attachment #828556 - Attachment is obsolete: true
Attachment #8342224 - Flags: review?(allstars.chh)
Assignee: gwang → nobody
Attachment #8342224 - Flags: review?(allstars.chh)
Add this in backlog.
blocking-b2g: --- → backlog
Whiteboard: [grooming]
blocking-b2g: backlog → ---
Blocks: 1157082
Assignee: nobody → jdai
No longer work on this.
Assignee: jdai → nobody
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: