Closed
Bug 914659
Opened 11 years ago
Closed 7 years ago
B2G RIL: Writing marionette test for removing ICC Contact
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(tracking-b2g:backlog)
RESOLVED
WONTFIX
tracking-b2g | backlog |
People
(Reporter: allstars.chh, Unassigned)
References
Details
(Whiteboard: [grooming])
Attachments
(1 file, 2 obsolete files)
4.01 KB,
patch
|
Details | Diff | Splinter Review |
Currently in marionette tests for icc contact, we only test reading and adding.
We also need to have tests for removing.
Updated•11 years ago
|
Assignee: nobody → gwang
Comment 2•11 years ago
|
||
Attachment #828515 -
Attachment is obsolete: true
Comment 3•11 years ago
|
||
Here's the try result:
https://tbpl.mozilla.org/?tree=Try&rev=42eb76f0d655
Updated•11 years ago
|
Attachment #828556 -
Flags: review?(allstars.chh)
Reporter | ||
Comment 4•11 years ago
|
||
Comment on attachment 828556 [details] [diff] [review]
Add remove contact marionette test.
Review of attachment 828556 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/icc/tests/marionette/test_icc_contact.js
@@ +99,5 @@
> + updateRequest.onsuccess = function onsuccess() {
> + if (type === "fdn" && pin2 === undefined) {
> + ok(false, "Should not update fdn when pin2 is not provided");
> + runNextTest();
> + }
I don't understand what you're tring to do here.
@@ +108,5 @@
> + getRequest.onsuccess = function onsuccess() {
> + let contacts = getRequest.result;
> +
> + // There are 4 SIM contacts which are harded in emulator
> + is(contacts.length, 4);
What's this check for ?
@@ +159,5 @@
> + testRemoveContact("fdn");
> +}
> +
> +function testRemoveFdnContactWithoutPassingPin2() {
> + testRemoveContact("fdn", "0000");
WithPassingPin2?
what's "0000" here?
Attachment #828556 -
Flags: review?(allstars.chh) → review-
Comment 5•11 years ago
|
||
(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #4)
> Comment on attachment 828556 [details] [diff] [review]
> Add remove contact marionette test.
>
> Review of attachment 828556 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: dom/icc/tests/marionette/test_icc_contact.js
> @@ +99,5 @@
> > + updateRequest.onsuccess = function onsuccess() {
> > + if (type === "fdn" && pin2 === undefined) {
> > + ok(false, "Should not update fdn when pin2 is not provided");
> > + runNextTest();
> > + }
>
> I don't understand what you're tring to do here.
There's no check for: no pin2 but update FDN case.
like Bug 935399. So I want to add test for this part.
> @@ +108,5 @@
> > + getRequest.onsuccess = function onsuccess() {
> > + let contacts = getRequest.result;
> > +
> > + // There are 4 SIM contacts which are harded in emulator
> > + is(contacts.length, 4);
>
> What's this check for ?
In previous test, we add contact id = 5 in both ADN and FDN.
So if we remove contactId = 5, there should be only 4 contacts as default.
> @@ +159,5 @@
> > + testRemoveContact("fdn");
> > +}
> > +
> > +function testRemoveFdnContactWithoutPassingPin2() {
> > + testRemoveContact("fdn", "0000");
>
> WithPassingPin2?
>
> what's "0000" here?
Sorry, the name should be switch between the two functions.
Since the code here has some change for multiple ICCs, I made some change and will update patch later.
Comment 6•11 years ago
|
||
Attachment #828556 -
Attachment is obsolete: true
Comment 7•11 years ago
|
||
Updated•11 years ago
|
Attachment #8342224 -
Flags: review?(allstars.chh)
Updated•11 years ago
|
Assignee: gwang → nobody
Reporter | ||
Updated•11 years ago
|
Attachment #8342224 -
Flags: review?(allstars.chh)
Updated•10 years ago
|
Whiteboard: [grooming]
Assignee | ||
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
Updated•9 years ago
|
Assignee: nobody → jdai
Reporter | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•