All users were logged out of Bugzilla on October 13th, 2018

B2G RIL: Writing marionette test for removing ICC Contact

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
5 years ago
a year ago

People

(Reporter: allstars.chh, Unassigned)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

(Whiteboard: [grooming])

Attachments

(1 attachment, 2 obsolete attachments)

Currently in marionette tests for icc contact, we only test reading and adding.
We also need to have tests for removing.

Updated

5 years ago
Assignee: nobody → gwang

Updated

5 years ago
Depends on: 935399

Comment 2

5 years ago
Created attachment 828556 [details] [diff] [review]
Add remove contact marionette test.
Attachment #828515 - Attachment is obsolete: true

Updated

5 years ago
Attachment #828556 - Flags: review?(allstars.chh)
Comment on attachment 828556 [details] [diff] [review]
Add remove contact marionette test.

Review of attachment 828556 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/icc/tests/marionette/test_icc_contact.js
@@ +99,5 @@
> +  updateRequest.onsuccess = function onsuccess() {
> +    if (type === "fdn" && pin2 === undefined) {
> +      ok(false, "Should not update fdn when pin2 is not provided");
> +      runNextTest();
> +    }

I don't understand what you're tring to do here.

@@ +108,5 @@
> +    getRequest.onsuccess = function onsuccess() {
> +      let contacts = getRequest.result;
> +
> +      // There are 4 SIM contacts which are harded in emulator
> +      is(contacts.length, 4);

What's this check for ?

@@ +159,5 @@
> +  testRemoveContact("fdn");
> +}
> +
> +function testRemoveFdnContactWithoutPassingPin2() {
> +  testRemoveContact("fdn", "0000");

WithPassingPin2?

what's "0000" here?
Attachment #828556 - Flags: review?(allstars.chh) → review-

Comment 5

5 years ago
(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #4)
> Comment on attachment 828556 [details] [diff] [review]
> Add remove contact marionette test.
> 
> Review of attachment 828556 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/icc/tests/marionette/test_icc_contact.js
> @@ +99,5 @@
> > +  updateRequest.onsuccess = function onsuccess() {
> > +    if (type === "fdn" && pin2 === undefined) {
> > +      ok(false, "Should not update fdn when pin2 is not provided");
> > +      runNextTest();
> > +    }
> 
> I don't understand what you're tring to do here.
There's no check for: no pin2 but update FDN case. 
like Bug 935399. So I want to add test for this part.


> @@ +108,5 @@
> > +    getRequest.onsuccess = function onsuccess() {
> > +      let contacts = getRequest.result;
> > +
> > +      // There are 4 SIM contacts which are harded in emulator
> > +      is(contacts.length, 4);
> 
> What's this check for ?
In previous test, we add contact id = 5 in both ADN and FDN.
So if we remove contactId = 5, there should be only 4 contacts as default.

> @@ +159,5 @@
> > +  testRemoveContact("fdn");
> > +}
> > +
> > +function testRemoveFdnContactWithoutPassingPin2() {
> > +  testRemoveContact("fdn", "0000");
> 
> WithPassingPin2?
> 
> what's "0000" here?

Sorry, the name should be switch between the two functions.

Since the code here has some change for multiple ICCs, I made some change and will update patch later.

Comment 6

5 years ago
Created attachment 8342224 [details] [diff] [review]
Add remove contact marionette test. v2
Attachment #828556 - Attachment is obsolete: true

Updated

5 years ago
Attachment #8342224 - Flags: review?(allstars.chh)

Updated

5 years ago
Assignee: gwang → nobody
(Reporter)

Updated

5 years ago
Attachment #8342224 - Flags: review?(allstars.chh)

Comment 8

5 years ago
Add this in backlog.
blocking-b2g: --- → backlog
Whiteboard: [grooming]
(Assignee)

Updated

4 years ago
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog

Updated

4 years ago
Blocks: 1157082

Updated

4 years ago
Assignee: nobody → jdai

Comment 9

3 years ago
No longer work on this.
Assignee: jdai → nobody
(Reporter)

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.