935399 - B2G RIL: check pin2 doesn't work when updating FDN

Status: RESOLVED DUPLICATE of bug 814637

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

+++ This bug was initially created as a clone of Bug #915986 +++

I found if someone call "icc.updateContact("fdn", contact)" without |pin2|, RIL will get "undefined" in pin2 and the check, |if(!pin2)|, doesn't work [1].

11-06 06:29:20.123    45   135 I Gecko   : RIL Worker[0]: Received chrome message {"requestId":"id{eae887c6-8818-495c-a426-13851574a04d}","contactType":"fdn","contact":{"alphaId":"add","number":"0912345678","id":"undefined"},"pin2":"undefined","rilMessageToken":12,"rilMessageType":"updateICCContact"}

It seems a XPCOM/IDL issue [2], I guess we may need a |pin2 === "undefined"| check here.

[1] http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js?from=ril_worker.js#l12609
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=808220#c16

Comment 1

[Edgar Chen [:edgar]]

Attachment: Patch, v1

1). Add |pin2 === "undefined"|
2). Correct marionette tests for fdn contact.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 827890 [details] [diff] [review]
Patch, v1

Review of attachment 827890 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +12606,5 @@
>          }
>          break;
>        case "fdn":
> +        // Workaround an xpconnect issue with undefined string objects.
> +        // See bug 935399.

Isn't this bug 935399?

Comment 3

[Edgar Chen [:edgar]]

In bug 814637, we are going to move MozIcc to webidl. The optional parameter in webidl we can use,

if(!aPin.WasPassed()) {
 // Pass null to provider interface.
 ....
}

This can solve the undefined string issue. And the test will also be addressed in bug 814637.