Closed Bug 914857 Opened 6 years ago Closed 6 years ago

Remove progress popup notification on errors

Categories

(Firefox Graveyard :: Web Apps, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch stop_progress_on_errors (obsolete) — Splinter Review
We should remove the progress popup notification when the mozApps API fails to install an application.
Attachment #802601 - Flags: review?(felipc)
Attached patch Patch (obsolete) — Splinter Review
Try run here: https://tbpl.mozilla.org/?tree=Try&rev=706c5dd4ccea
Assignee: nobody → mcastelluccio
Attachment #802601 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #802601 - Flags: review?(felipc)
Attachment #804906 - Flags: review?(felipc)
Comment on attachment 804906 [details] [diff] [review]
Patch

Review of attachment 804906 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/modules/webappsUI.jsm
@@ +21,5 @@
>                                     "@mozilla.org/childprocessmessagemanager;1",
>                                     "nsIMessageSender");
>  
>  this.webappsUI = {
> +  installations: {},

just add a comment here saying this is a list of promises for installations that are in progress.

We could also change the name of the variable to make it more clear, but it would probably get too big.  installsInProgress or something?  I guess if the comment is clear enough it's not necessary, but "installations" gives me the sense of "currently installed apps"
Attachment #804906 - Flags: review?(felipc) → review+
Attached patch PatchSplinter Review
Thank you for the quick review!
Attachment #804906 - Attachment is obsolete: true
Attachment #804981 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/de540bd0137e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.