Remove progress popup notification on errors

RESOLVED FIXED in Firefox 26

Status

Firefox Graveyard
Web Apps
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: marco, Assigned: marco)

Tracking

Trunk
Firefox 26

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 802601 [details] [diff] [review]
stop_progress_on_errors

We should remove the progress popup notification when the mozApps API fails to install an application.
Attachment #802601 - Flags: review?(felipc)
(Assignee)

Comment 1

5 years ago
Created attachment 804906 [details] [diff] [review]
Patch

Try run here: https://tbpl.mozilla.org/?tree=Try&rev=706c5dd4ccea
Assignee: nobody → mcastelluccio
Attachment #802601 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #802601 - Flags: review?(felipc)
Attachment #804906 - Flags: review?(felipc)
Comment on attachment 804906 [details] [diff] [review]
Patch

Review of attachment 804906 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/modules/webappsUI.jsm
@@ +21,5 @@
>                                     "@mozilla.org/childprocessmessagemanager;1",
>                                     "nsIMessageSender");
>  
>  this.webappsUI = {
> +  installations: {},

just add a comment here saying this is a list of promises for installations that are in progress.

We could also change the name of the variable to make it more clear, but it would probably get too big.  installsInProgress or something?  I guess if the comment is clear enough it's not necessary, but "installations" gives me the sense of "currently installed apps"
Attachment #804906 - Flags: review?(felipc) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 804981 [details] [diff] [review]
Patch

Thank you for the quick review!
Attachment #804906 - Attachment is obsolete: true
Attachment #804981 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/de540bd0137e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.