Closed Bug 914937 Opened 6 years ago Closed 6 years ago

Remove nsFlexContainerFrame's GetSkipSides specialization, now that it can inherit one from nsSplittableFrame

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

I added nsFlexContainerFrame::GetSkipSides in bug 870555, basically copypasted from nsBlockFrame's specialization.

Since then, bug 743402 *removed* nsBlockFrame's specialization[1], and promoted it (with improvements) to live on nsSplittableFrame, which nsFlexContainerFrame derives from.

So, we can remove nsFlexContainerFrame::GetSkipSides() now, and just use the inherited version.

[1] https://hg.mozilla.org/mozilla-central/rev/352501d3f390#l1.12
Comment on attachment 802727 [details] [diff] [review]
fix

r=mats
Attachment #802727 - Flags: review?(matspal) → review+
https://hg.mozilla.org/mozilla-central/rev/02a38c597287
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.