Remove nsFlexContainerFrame's GetSkipSides specialization, now that it can inherit one from nsSplittableFrame

RESOLVED FIXED in mozilla26

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla26
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I added nsFlexContainerFrame::GetSkipSides in bug 870555, basically copypasted from nsBlockFrame's specialization.

Since then, bug 743402 *removed* nsBlockFrame's specialization[1], and promoted it (with improvements) to live on nsSplittableFrame, which nsFlexContainerFrame derives from.

So, we can remove nsFlexContainerFrame::GetSkipSides() now, and just use the inherited version.

[1] https://hg.mozilla.org/mozilla-central/rev/352501d3f390#l1.12
Created attachment 802727 [details] [diff] [review]
fix
Attachment #802727 - Flags: review?(matspal)
Comment on attachment 802727 [details] [diff] [review]
fix

r=mats
Attachment #802727 - Flags: review?(matspal) → review+

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/02a38c597287
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.