914954 - Myanmar font is not available in B2G

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Kai-Zhen Li [:seinlin][:kli]]

Step to reproduce: Visit a web site with Myanmar Unicode text, 
                   such as: http://www.bbc.co.uk/burmese/

Expected result: Unicode Myanmar text does render properly.

Actual result: Unicode Myanmar text doesn't render properly.

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-914954-pull-request.html

Add Myanmar font for B2G.

Comment 2

[Michael Wu [:mwu]]

Jonathon/Patryk, any thoughts?

Comment 3

[Michael Wu [:mwu]]

Comment on attachment 802908 [details]
bug-914954-pull-request.html

Clearing review since this is bitrotted and we'll also need to make a decision about if this font is ok.

Comment 4

[Jonathan Kew [:jfkthame]]

I have some concerns about the font here - we would at least need to look into it more closely before making a decision.

On a technical level, it does not follow the Microsoft shaping spec for Myanmar (it was developed before that spec appeared, AFAICT), but instead relies on "generic" ligature features for all the Myanmar shaping. We'd need to look into how well this works in conjunction with our text-shaping code.

There are also licensing concerns we should check. The font says it is GPL; can we incorporate that into the B2G product? And it includes a set of Latin glyphs that look to me like they may have been copied directly from Times Roman. We'd need to know the provenance of those glyphs in order to be confident whether the licensing is legitimate.

Another possibility might be to use SIL's Padauk font (http://scripts.sil.org/cms/scripts/page.php?item_id=Padauk).

Comment 5

[Patryk Adamczyk [:patryk] UX]

Agreed with Jonathan, safer bet is to include SIL's Padauk. 

We also have been getting requests from OEMs to swap out fonts, so there is a good chance if we ever officially ship in those countries we might get an OEM designed font for that region.

Comment 6

[Kai-Zhen Li [:seinlin][:kli]]

SIL's Padauk is also a good choice. 

Now I've finished the Myanmar Keyboard layout, but without a Myanmar it can be rendered correctly.

Do you think we can add the Padauk?

Comment 7

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Padauk_font.jpg

A sample image with Padauk font. It looks good.

Comment 8

[Michael Wu [:mwu]]

(In reply to kli from comment #6)
> Do you think we can add the Padauk?

Sounds like that's the consensus now. Want to send a pull request?

Comment 9

[Kai-Zhen Li [:seinlin][:kli]]

(In reply to Michael Wu [:mwu] from comment #8)
> (In reply to kli from comment #6)
> > Do you think we can add the Padauk?
> 
> Sounds like that's the consensus now. Want to send a pull request?

Yes, I updated the pull request.

Comment 10

[Michael Wu [:mwu]]

Pull request looks good. Just two nits -

1. Move the location of this in the list before Roboto so the list remains alphabetized.
2. Fold everything into a single commit.

Comment 11

[Kai-Zhen Li [:seinlin][:kli]]

Hi Michael, Thanks! 

Pull request is updated.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/moztt/commit/74f96653db50b9c2a382d67000580f375fa49e96