915085 - Pre-defined apps should appear in Collections

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Cristian Rodriguez (:crdlc)]

Apps included in the grid should be linked to a Smart Collection

Comment 1

[Cristian Rodriguez (:crdlc)]

I've had the same implementation to support this new feature

https://github.com/crdlc/gaia/commit/f81e0f4ad46ac4e199e23b61952b99c08c57d9c7

Comment 2

[Cristian Rodriguez (:crdlc)]

Current mapping:

* Funny: video
* Games: marketplace
* Music: fm, music and video
* Photography: camera and gallery
* Social: dialer, sms, contacts and email
* TV: video
* Utilities: Browser, settings, marketplace, calendar, clock and cost control

Dani, is it OK? Thanks

Comment 3

[Daniel Coloma:dcoloma]

OK by me

Comment 4

[Simon Callan, Telefonica]

how are we handling 3rd party pre-installed apps:

(1) do they appear in a collection as well? If so we need to start mapping them in grids
(2) will they look different/be positioned differently than standard e.me apps (we have contactual commitments on placement with some partners)

Comment 5

[Daniel Coloma:dcoloma]

The 3rd apps will be still positioned in the same way, the only difference is that we can (and we should) assign them to 1 or more collection

Comment 6

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 809859 [details]
Patch v1

Ran review should be enough for that.

Comment 8

[Ran Ben Aharon [:ranbena] EverythingMe]

Pre installed apps already appear in Collections BUT a network connection on first time use is required.
This feature would allow to define apps in Collections in their manifests.

Moreover, the apps that are predefined, should appear first and in the defined order.

Comment 9

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/8896f59c509c40c802976ad0852fd96843ddfefe

Comment 10

[James Lal [:lightsofapollo]]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 8896f59c509c40c802976ad0852fd96843ddfefe
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 11

[Cristian Rodriguez (:crdlc)]

It depends on bug 911958

Comment 12

[Jason Smith [:jsmith]]

Per a recent release drivers discussion, we need to hold off on uplifting this to 1.2 until we confirm a path forward post the planned e.me 1.2 status meeting tomorrow.

Comment 13

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #12)
> Per a recent release drivers discussion, we need to hold off on uplifting
> this to 1.2 until we confirm a path forward post the planned e.me 1.2 status
> meeting tomorrow.

e.me 1.2 changes have been moved to 1.3, so moving flags.